[PR #121] [MERGED] Fix build upload State type and handle empty checksums #303

New issue

Closed

opened 2026-02-26 21:34:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/121
Author: @swiftlysingh
Created: 1/24/2026
Status: ✅ Merged
Merged: 1/24/2026
Merged by: @rudrankriyam

Base: cursor/build-upload-full-flow-06db ← Head: fix/build-upload-improvements

📝 Commits (1)

093b64d Fix build upload State type and handle empty checksums gracefully

📊 Changes

2 files changed (+16 additions, -14 deletions)

View changed files

📝 cmd/builds_commands.go (+11 -9)
📝 internal/asc/client_builds.go (+5 -5)

📄 Description

Summary

Fixes two issues found during end-to-end testing of #100 with a real IPA upload to App Store Connect.

Fix BuildUploadAttributes.State type — The API returns state as an object (with state, errors, warnings fields), not a plain string. Changed from *string to *AppMediaAssetState so the response can be deserialized. Without this fix, every upload attempt fails with a JSON unmarshal error.
Handle empty checksums gracefully — When --checksum is requested but the API returns a sourceFileChecksums object with no actual algorithms populated, the command now prints a warning to stderr and continues instead of failing. This matches real-world API behavior where checksums aren't always provided.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/121 **Author:** [@swiftlysingh](https://github.com/swiftlysingh) **Created:** 1/24/2026 **Status:** ✅ Merged **Merged:** 1/24/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `cursor/build-upload-full-flow-06db` ← **Head:** `fix/build-upload-improvements` --- ### 📝 Commits (1) - [`093b64d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/093b64d272032c874233d8f0fe1568c8d06c164d) Fix build upload State type and handle empty checksums gracefully ### 📊 Changes **2 files changed** (+16 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `cmd/builds_commands.go` (+11 -9) 📝 `internal/asc/client_builds.go` (+5 -5) </details> ### 📄 Description ## Summary Fixes two issues found during end-to-end testing of #100 with a real IPA upload to App Store Connect. - **Fix `BuildUploadAttributes.State` type** — The API returns `state` as an object (with `state`, `errors`, `warnings` fields), not a plain string. Changed from `*string` to `*AppMediaAssetState` so the response can be deserialized. Without this fix, every upload attempt fails with a JSON unmarshal error. - **Handle empty checksums gracefully** — When `--checksum` is requested but the API returns a `sourceFileChecksums` object with no actual algorithms populated, the command now prints a warning to stderr and continues instead of failing. This matches real-world API behavior where checksums aren't always provided. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>