[PR #226] [MERGED] feat: add nominations commands #370

New issue

Closed

opened 2026-02-26 21:34:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/226
Author: @rudrankriyam
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/27/2026
Merged by: @rudrankriyam

Base: main ← Head: pr-204

📝 Commits (7)

847ea28 feat: add nominations commands
726bc70 Remove unused nominations relationship helper
3c26f57 Merge pull request #228 from rudrankriyam/cursor/nominations-unused-function-fa5a
4934089 Merge main into pr-204
48dfd09 Add nominations pagination support
a87cc3b Merge pull request #235 from rudrankriyam/cursor/nominations-pagination-type-d50c
b750129 Merge origin/main into pr-204

📊 Changes

12 files changed (+1959 additions, -0 deletions)

View changed files

➕ cmd/nominations.go (+924 -0)
➕ cmd/nominations_test.go (+117 -0)
📝 cmd/root.go (+1 -0)
📝 internal/asc/client_options.go (+92 -0)
📝 internal/asc/client_pagination.go (+4 -0)
📝 internal/asc/client_queries.go (+52 -0)
📝 internal/asc/client_test.go (+350 -0)
📝 internal/asc/client_types.go (+1 -0)
➕ internal/asc/nominations.go (+261 -0)
➕ internal/asc/nominations_output.go (+55 -0)
📝 internal/asc/output_core.go (+12 -0)
📝 internal/asc/output_test.go (+90 -0)

📄 Description

Summary

add asc nominations command group (list/get/create/update/delete)
add nominations client/query/output plumbing and validation
add tests for CLI and output rendering

Test plan

make test
Manual (ASC_BYPASS_KEYCHAIN=1):
- ./asc nominations list --status DRAFT --app 6740467361 --output table
- ./asc nominations create --app 6740467361 --name "ASC Nomination A" --type APP_LAUNCH --description "API test nomination A" --submitted=false --publish-start-date "2026-02-10T08:00:00Z" --output table
- ./asc nominations get --id <nomination-id> --output table
- ./asc nominations update --id <nomination-id> --submitted=false --notes "Updated notes A" --output table
- ./asc nominations delete --id <nomination-id> --confirm --output table
- ./asc nominations list --status DRAFT --app 6747745091 --output table
- ./asc nominations create --app 6747745091 --name "ASC Nomination B" --type APP_ENHANCEMENTS --description "API test nomination B" --submitted=false --publish-start-date "2026-02-12T08:00:00Z" --output table
- ./asc nominations get --id <nomination-id> --output table
- ./asc nominations update --id <nomination-id> --submitted=false --notes "Updated notes B" --output table
- ./asc nominations delete --id <nomination-id> --confirm --output table

Notes

Update requires --submitted or --archived per API behavior (not indicated in OpenAPI).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/226 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/27/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `pr-204` --- ### 📝 Commits (7) - [`847ea28`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/847ea28ceb1123ccf513ae9bb1376c82cc9794d8) feat: add nominations commands - [`726bc70`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/726bc7050e8d8022da1e61feaf45ec2ca3b60bc5) Remove unused nominations relationship helper - [`3c26f57`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3c26f5724419e22be20ff75134399bed36f75f93) Merge pull request #228 from rudrankriyam/cursor/nominations-unused-function-fa5a - [`4934089`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/493408923ed30baf3877ef53dcc76eb6e243638b) Merge main into pr-204 - [`48dfd09`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/48dfd095b16d7bfa4b550944db42659981197cca) Add nominations pagination support - [`a87cc3b`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a87cc3b971606b42ea26b6f28f675ac43d0283cf) Merge pull request #235 from rudrankriyam/cursor/nominations-pagination-type-d50c - [`b750129`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b750129ae8fce938beda2a12679bd6ffe8a79c7d) Merge origin/main into pr-204 ### 📊 Changes **12 files changed** (+1959 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `cmd/nominations.go` (+924 -0) ➕ `cmd/nominations_test.go` (+117 -0) 📝 `cmd/root.go` (+1 -0) 📝 `internal/asc/client_options.go` (+92 -0) 📝 `internal/asc/client_pagination.go` (+4 -0) 📝 `internal/asc/client_queries.go` (+52 -0) 📝 `internal/asc/client_test.go` (+350 -0) 📝 `internal/asc/client_types.go` (+1 -0) ➕ `internal/asc/nominations.go` (+261 -0) ➕ `internal/asc/nominations_output.go` (+55 -0) 📝 `internal/asc/output_core.go` (+12 -0) 📝 `internal/asc/output_test.go` (+90 -0) </details> ### 📄 Description ## Summary - add `asc nominations` command group (list/get/create/update/delete) - add nominations client/query/output plumbing and validation - add tests for CLI and output rendering ## Test plan - `make test` - Manual (ASC_BYPASS_KEYCHAIN=1): - `./asc nominations list --status DRAFT --app 6740467361 --output table` - `./asc nominations create --app 6740467361 --name "ASC Nomination A" --type APP_LAUNCH --description "API test nomination A" --submitted=false --publish-start-date "2026-02-10T08:00:00Z" --output table` - `./asc nominations get --id <nomination-id> --output table` - `./asc nominations update --id <nomination-id> --submitted=false --notes "Updated notes A" --output table` - `./asc nominations delete --id <nomination-id> --confirm --output table` - `./asc nominations list --status DRAFT --app 6747745091 --output table` - `./asc nominations create --app 6747745091 --name "ASC Nomination B" --type APP_ENHANCEMENTS --description "API test nomination B" --submitted=false --publish-start-date "2026-02-12T08:00:00Z" --output table` - `./asc nominations get --id <nomination-id> --output table` - `./asc nominations update --id <nomination-id> --submitted=false --notes "Updated notes B" --output table` - `./asc nominations delete --id <nomination-id> --confirm --output table` ## Notes - Update requires `--submitted` or `--archived` per API behavior (not indicated in OpenAPI). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>