[PR #14] [MERGED] Standardize build upload types and outputs #226

New issue

Closed

opened 2026-02-26 21:34:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/14
Author: @rudrankriyam
Created: 1/20/2026
Status: ✅ Merged
Merged: 1/20/2026
Merged by: @rudrankriyam

Base: main ← Head: feature/build-upload-submit-plan

📝 Commits (2)

84e0c6e Standardize build upload types and outputs
fb5c5bb Harden builds upload validation tests

📊 Changes

8 files changed (+1488 additions, -30 deletions)

View changed files

📝 Agents.md (+16 -0)
📝 cmd/commands.go (+253 -13)
📝 cmd/commands_test.go (+88 -0)
📝 internal/asc/client.go (+442 -13)
📝 internal/asc/client_http_test.go (+312 -0)
📝 internal/asc/client_test.go (+275 -2)
📝 internal/asc/output_test.go (+100 -0)
📝 internal/config/config.go (+2 -2)

📄 Description

Summary

add typed resource/asset enums with pointer optional fields for build upload/submission models
extend build upload/submission outputs to table/markdown printers
expand client/command tests for JSON structure, validation, and API error paths

Test plan

go test ./...

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/14 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/20/2026 **Status:** ✅ Merged **Merged:** 1/20/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feature/build-upload-submit-plan` --- ### 📝 Commits (2) - [`84e0c6e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/84e0c6e8588bb463f620661c3ac9e25f2970bf97) Standardize build upload types and outputs - [`fb5c5bb`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/fb5c5bb2fdf332fd61281cbaa36c86c8c27ff68b) Harden builds upload validation tests ### 📊 Changes **8 files changed** (+1488 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `Agents.md` (+16 -0) 📝 `cmd/commands.go` (+253 -13) 📝 `cmd/commands_test.go` (+88 -0) 📝 `internal/asc/client.go` (+442 -13) 📝 `internal/asc/client_http_test.go` (+312 -0) 📝 `internal/asc/client_test.go` (+275 -2) 📝 `internal/asc/output_test.go` (+100 -0) 📝 `internal/config/config.go` (+2 -2) </details> ### 📄 Description ## Summary - add typed resource/asset enums with pointer optional fields for build upload/submission models - extend build upload/submission outputs to table/markdown printers - expand client/command tests for JSON structure, validation, and API error paths ## Test plan - [ ] go test ./... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>