[GH-ISSUE #620] coverage: Add missing Xcode Cloud (CI/SCM) relationship endpoints (OpenAPI) #177

New issue

Closed

opened 2026-02-26 21:33:54 +03:00 by kerem · 3 comments

kerem commented

2026-02-26 21:33:54 +03:00

Owner

Copy link

Originally created by @rudrankriyam on GitHub (Feb 18, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/620

Context

These endpoints exist in the offline OpenAPI snapshot (docs/openapi/latest.json, indexed by docs/openapi/paths.txt) but are currently missing from internal/asc client coverage.

Goal

Add ASC client methods for the endpoints below (method + path).

Missing endpoints

GET /v1/ciBuildActions/{id}/relationships/artifacts
GET /v1/ciBuildActions/{id}/relationships/buildRun
GET /v1/ciBuildActions/{id}/relationships/issues
GET /v1/ciBuildActions/{id}/relationships/testResults
GET /v1/ciBuildRuns/{id}/relationships/actions
GET /v1/ciBuildRuns/{id}/relationships/builds
GET /v1/ciMacOsVersions/{id}/relationships/xcodeVersions
GET /v1/ciProducts/{id}/relationships/additionalRepositories
GET /v1/ciProducts/{id}/relationships/app
GET /v1/ciProducts/{id}/relationships/buildRuns
GET /v1/ciProducts/{id}/relationships/primaryRepositories
GET /v1/ciProducts/{id}/relationships/workflows
GET /v1/ciWorkflows/{id}/relationships/buildRuns
GET /v1/ciWorkflows/{id}/relationships/repository
GET /v1/ciXcodeVersions/{id}/relationships/macOsVersions
GET /v1/scmProviders/{id}/relationships/repositories

Where/what to add

Implement in internal/asc/xcode_cloud.go (or a new internal/asc/client_xcode_cloud_relationships.go).
Relationship GETs should return LinkagesResponse with LinkagesOption support (limit/next).
Tests: request-shaping tests using newTestClient (method/path/query).

Test plan

Add request-shaping tests using newTestClient (assert method + path + query).
For mutation endpoints (POST/PATCH/DELETE), assert request method + path and (when applicable) JSON relationship payload shape.

Acceptance criteria

All endpoints listed are implemented in internal/asc with tests.
ASC_BYPASS_KEYCHAIN=1 make test passes.

Originally created by @rudrankriyam on GitHub (Feb 18, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/620 ## Context These endpoints exist in the offline OpenAPI snapshot (`docs/openapi/latest.json`, indexed by `docs/openapi/paths.txt`) but are currently missing from `internal/asc` client coverage. ## Goal Add ASC client methods for the endpoints below (method + path). ## Missing endpoints - [ ] GET /v1/ciBuildActions/{id}/relationships/artifacts - [ ] GET /v1/ciBuildActions/{id}/relationships/buildRun - [ ] GET /v1/ciBuildActions/{id}/relationships/issues - [ ] GET /v1/ciBuildActions/{id}/relationships/testResults - [ ] GET /v1/ciBuildRuns/{id}/relationships/actions - [ ] GET /v1/ciBuildRuns/{id}/relationships/builds - [ ] GET /v1/ciMacOsVersions/{id}/relationships/xcodeVersions - [ ] GET /v1/ciProducts/{id}/relationships/additionalRepositories - [ ] GET /v1/ciProducts/{id}/relationships/app - [ ] GET /v1/ciProducts/{id}/relationships/buildRuns - [ ] GET /v1/ciProducts/{id}/relationships/primaryRepositories - [ ] GET /v1/ciProducts/{id}/relationships/workflows - [ ] GET /v1/ciWorkflows/{id}/relationships/buildRuns - [ ] GET /v1/ciWorkflows/{id}/relationships/repository - [ ] GET /v1/ciXcodeVersions/{id}/relationships/macOsVersions - [ ] GET /v1/scmProviders/{id}/relationships/repositories ## Where/what to add - Implement in `internal/asc/xcode_cloud.go` (or a new `internal/asc/client_xcode_cloud_relationships.go`). - Relationship GETs should return `LinkagesResponse` with `LinkagesOption` support (limit/next). - Tests: request-shaping tests using `newTestClient` (method/path/query). ## Test plan - Add request-shaping tests using `newTestClient` (assert method + path + query). - For mutation endpoints (POST/PATCH/DELETE), assert request method + path and (when applicable) JSON relationship payload shape. ## Acceptance criteria - All endpoints listed are implemented in `internal/asc` with tests. - `ASC_BYPASS_KEYCHAIN=1 make test` passes.

kerem

2026-02-26 21:33:54 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-02-26 21:33:55 +03:00

Author

Owner

Copy link

@rudrankriyam commented on GitHub (Feb 18, 2026):

@cursor please implement this issue (#620).

Scope: 16 missing Xcode Cloud (CI/SCM) relationship endpoints (GET-only).

Implementation notes:

These are /v1/ci.../relationships/... and /v1/scm.../relationships/... endpoints.
Be careful about to-one vs to-many relationship linkages. Use LinkagesResponse for to-many; for to-one, use a single-linkage response shape (Data ResourceData) like existing BuildAppLinkageResponse patterns.
Add request-shaping tests for each endpoint (method + path + query).

Acceptance:

All endpoints in the issue checklist are implemented in internal/asc/ with tests.
ASC_BYPASS_KEYCHAIN=1 make test passes.

@rudrankriyam commented on GitHub (Feb 18, 2026): @cursor please implement this issue (#620). Scope: 16 missing Xcode Cloud (CI/SCM) relationship endpoints (GET-only). Implementation notes: - These are `/v1/ci.../relationships/...` and `/v1/scm.../relationships/...` endpoints. - Be careful about to-one vs to-many relationship linkages. Use `LinkagesResponse` for to-many; for to-one, use a single-linkage response shape (`Data ResourceData`) like existing `BuildAppLinkageResponse` patterns. - Add request-shaping tests for each endpoint (method + path + query). Acceptance: - All endpoints in the issue checklist are implemented in `internal/asc/` with tests. - `ASC_BYPASS_KEYCHAIN=1 make test` passes.

kerem commented

2026-02-26 21:33:55 +03:00

Author

Owner

Copy link

@cursor[bot] commented on GitHub (Feb 18, 2026):

Implemented issue #620: added ASC client coverage + request-shaping tests for the 16 missing Xcode Cloud (CI/SCM) GET relationship endpoints.

What I added

New client methods in internal/asc/client_xcode_cloud_relationships.go:
- To-many relationship endpoints return *LinkagesResponse and accept ...LinkagesOption (limit/next):
  - GET /v1/ciBuildActions/{id}/relationships/artifacts
  - GET /v1/ciBuildActions/{id}/relationships/issues
  - GET /v1/ciBuildActions/{id}/relationships/testResults
  - GET /v1/ciBuildRuns/{id}/relationships/actions
  - GET /v1/ciBuildRuns/{id}/relationships/builds
  - GET /v1/ciMacOsVersions/{id}/relationships/xcodeVersions
  - GET /v1/ciProducts/{id}/relationships/additionalRepositories
  - GET /v1/ciProducts/{id}/relationships/buildRuns
  - GET /v1/ciProducts/{id}/relationships/primaryRepositories
  - GET /v1/ciProducts/{id}/relationships/workflows
  - GET /v1/ciWorkflows/{id}/relationships/buildRuns
  - GET /v1/ciXcodeVersions/{id}/relationships/macOsVersions
  - GET /v1/scmProviders/{id}/relationships/repositories
- To-one relationship endpoints return single-linkage response shapes (Data ResourceData) via new types:
  - GET /v1/ciBuildActions/{id}/relationships/buildRun → CiBuildActionBuildRunLinkageResponse
  - GET /v1/ciProducts/{id}/relationships/app → CiProductAppLinkageResponse
  - GET /v1/ciWorkflows/{id}/relationships/repository → CiWorkflowRepositoryLinkageResponse
New request-shaping tests in internal/asc/client_http_xcode_cloud_relationships_test.go asserting method + path + query (limit) and next URL passthrough for each to-many endpoint, plus basic GET/path checks for the 3 to-one endpoints.

Verification

ASC_BYPASS_KEYCHAIN=1 make test ✅
make lint ✅

@cursor[bot] commented on GitHub (Feb 18, 2026): Implemented issue #620: added ASC client coverage + request-shaping tests for the 16 missing Xcode Cloud (CI/SCM) **GET** relationship endpoints. ### What I added - New client methods in `internal/asc/client_xcode_cloud_relationships.go`: - **To-many** relationship endpoints return `*LinkagesResponse` and accept `...LinkagesOption` (limit/next): - `GET /v1/ciBuildActions/{id}/relationships/artifacts` - `GET /v1/ciBuildActions/{id}/relationships/issues` - `GET /v1/ciBuildActions/{id}/relationships/testResults` - `GET /v1/ciBuildRuns/{id}/relationships/actions` - `GET /v1/ciBuildRuns/{id}/relationships/builds` - `GET /v1/ciMacOsVersions/{id}/relationships/xcodeVersions` - `GET /v1/ciProducts/{id}/relationships/additionalRepositories` - `GET /v1/ciProducts/{id}/relationships/buildRuns` - `GET /v1/ciProducts/{id}/relationships/primaryRepositories` - `GET /v1/ciProducts/{id}/relationships/workflows` - `GET /v1/ciWorkflows/{id}/relationships/buildRuns` - `GET /v1/ciXcodeVersions/{id}/relationships/macOsVersions` - `GET /v1/scmProviders/{id}/relationships/repositories` - **To-one** relationship endpoints return single-linkage response shapes (`Data ResourceData`) via new types: - `GET /v1/ciBuildActions/{id}/relationships/buildRun` → `CiBuildActionBuildRunLinkageResponse` - `GET /v1/ciProducts/{id}/relationships/app` → `CiProductAppLinkageResponse` - `GET /v1/ciWorkflows/{id}/relationships/repository` → `CiWorkflowRepositoryLinkageResponse` - New request-shaping tests in `internal/asc/client_http_xcode_cloud_relationships_test.go` asserting **method + path + query** (limit) and **next URL passthrough** for each to-many endpoint, plus basic GET/path checks for the 3 to-one endpoints. ### Verification - `ASC_BYPASS_KEYCHAIN=1 make test` ✅ - `make lint` ✅ <p><a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/627"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a></p> <p><a href="https://cursor.com/background-agent?bcId=bc-99fb78b2-efbe-4f43-b197-e3a5a46cd7ca"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-99fb78b2-efbe-4f43-b197-e3a5a46cd7ca"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p>

kerem commented

2026-02-26 21:33:55 +03:00

Author

Owner

Copy link

@rudrankriyam commented on GitHub (Feb 18, 2026):

Closed by PR #627 (merged).

@rudrankriyam commented on GitHub (Feb 18, 2026): Closed by PR #627 (merged).

kerem referenced this issue

2026-02-26 21:34:39 +03:00

[PR #177] [MERGED] feat: add auth init --open helper #339

No Branch/Tag specified

main

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.1

1.1.0

1.0.1

1.0.0

0.49.1

0.49.0

0.48.1

0.48.0

0.47.1

0.47.0

0.46.2

0.46.1

0.46.0

0.45.4

0.45.3

0.45.2

0.45.1

0.45.0

0.44.2

0.44.1

0.44.0

0.43.0

0.42.0

0.41.4

0.41.3

0.41.2

0.41.1

0.41.0

0.40.1

0.40.0

0.39.1

0.39.0

0.38.3

0.38.2

0.38.1

0.38.0

0.37.3

0.37.2

0.37.1

0.37.0

0.36.3

0.36.2

0.36.1

0.36.0

0.35.3

0.35.2

0.35.1

0.35.0

0.34.1

0.34.0

0.33.2

0.33.1

0.33.0

0.32.0

0.31.3

0.31.2

0.31.1

0.31.0

0.30.0

0.29.3

0.29.2

0.29.1

0.29.0

0.28.14

0.28.13

0.28.12

0.28.11

0.28.10

0.28.9

0.28.8

0.28.7

0.28.6

0.28.5

0.28.4

0.28.3

0.28.2

0.28.1

0.28.0

0.27.0

0.26.4

0.26.3

0.26.2

0.26.1

0.26.0

0.25.4

0.25.3

0.25.1

0.25.0

0.24.3

0.24.2

0.24.1

0.24.0

0.23.5

0.23.4

0.23.3

0.23.2

0.23.1

0.23.0

0.22.1

0.22.0

0.21.0

0.20.2

0.20.1

0.20.0

0.19.3

0.19.2

0.19.1

0.19.0

0.18.2

0.18.1

0.18.0

0.17.0

0.16.0

0.15.0

0.14.0

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.0

0.10.2

0.10.1

0.10.0

0.9.0

0.8.1

0.8.0

0.7.0

0.6.0

0.5.0

0.3.1

0.3.0

0.2.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/App-Store-Connect-CLI#177

Reference in a new issue

Repository

starred/App-Store-Connect-CLI

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns