[PR #558] [MERGED] Empty build data validation #620

New issue

Closed

opened 2026-02-26 22:31:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/558
Author: @cursor[bot]
Created: 2/15/2026
Status: ✅ Merged
Merged: 2/15/2026
Merged by: @rudrankriyam

Base: validate/screenshot-presence ← Head: cursor/empty-build-data-validation-713b

📝 Commits (1)

2de21e7 validate: detect missing build when data is null

📊 Changes

2 files changed (+44 additions, -1 deletions)

View changed files

📝 internal/cli/cmdtest/validate_test.go (+43 -0)
📝 internal/cli/validate/validate.go (+1 -1)

📄 Description

Summary

Fixed a bug where the build readiness check would incorrectly pass if the App Store Connect API returned a successful response for a build relationship, but with empty data or data.id. This ensures build.required.missing is correctly reported in such edge cases.

Validation

make format
make lint
make test

Wall of Apps (only if this PR adds/updates a Wall app)

I ran make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..." (or manually edited docs/wall-of-apps.json + ran make update-wall-of-apps)
I committed all generated files:
- docs/wall-of-apps.json
- README.md

Entry template:

{
  "app": "Your App Name",
  "link": "https://apps.apple.com/app/id1234567890",
  "creator": "your-github-handle",
  "platform": ["iOS"]
}

Common Apple labels: iOS, macOS, watchOS, tvOS, visionOS.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/558 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/15/2026 **Status:** ✅ Merged **Merged:** 2/15/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `validate/screenshot-presence` ← **Head:** `cursor/empty-build-data-validation-713b` --- ### 📝 Commits (1) - [`2de21e7`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/2de21e7e4ea861e2c3a5655e23031c2a230d3de2) validate: detect missing build when data is null ### 📊 Changes **2 files changed** (+44 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/validate_test.go` (+43 -0) 📝 `internal/cli/validate/validate.go` (+1 -1) </details> ### 📄 Description ## Summary - Fixed a bug where the build readiness check would incorrectly pass if the App Store Connect API returned a successful response for a build relationship, but with empty `data` or `data.id`. This ensures `build.required.missing` is correctly reported in such edge cases. ## Validation - [x] `make format` - [x] `make lint` - [x] `make test` ## Wall of Apps (only if this PR adds/updates a Wall app) - [ ] I ran `make generate app APP="..." LINK="..." CREATOR="..." PLATFORM="..."` (or manually edited `docs/wall-of-apps.json` + ran `make update-wall-of-apps`) - [ ] I committed all generated files: - `docs/wall-of-apps.json` - `README.md` Entry template: ```json { "app": "Your App Name", "link": "https://apps.apple.com/app/id1234567890", "creator": "your-github-handle", "platform": ["iOS"] } ``` Common Apple labels: `iOS`, `macOS`, `watchOS`, `tvOS`, `visionOS`. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>