starred/App-Store-Connect-CLI
1
0
Fork 0
mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 15:45:48 +03:00
Code Issues 2 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #555] validate warns about empty whatsNew on initial v1.0 releases #151

New issue
Closed
opened 2026-02-26 21:33:48 +03:00 by kerem · 4 comments
kerem commented 2026-02-26 21:33:48 +03:00
Owner
Copy link

Originally created by @danfry1 on GitHub (Feb 15, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/555

Description

The validate command warns about an empty whatsNew field on initial App Store releases (v1.0), but Apple doesn't support "What's New" for first submissions — only for updates.

Steps to Reproduce

  1. Have an app with an initial v1.0 in WAITING_FOR_REVIEW state
  2. Run asc validate --app "APP_ID" --version-id "VERSION_ID" --platform IOS --strict

Actual Behavior

│ warning │ metadata.required.whats_new │ en-US │ whatsNew │ ... │ what's new is empty │ Provide release notes for this localization │

With --strict, this causes a non-zero exit code.

Expected Behavior

The validate command should skip the whatsNew check for initial releases (v1.0), since Apple does not allow setting it.

Notes

The localizations upload command already handles this correctly — when uploading with a whatsNew value on a v1.0 release, it prints:

Warning: 'whatsNew' cannot be set for this version (initial releases have no What's New section). Retrying without it.

So the awareness is already there in the upload path, just not in the validate path.

Originally created by @danfry1 on GitHub (Feb 15, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/555 ## Description The `validate` command warns about an empty `whatsNew` field on initial App Store releases (v1.0), but Apple doesn't support "What's New" for first submissions — only for updates. ## Steps to Reproduce 1. Have an app with an initial v1.0 in WAITING_FOR_REVIEW state 2. Run `asc validate --app "APP_ID" --version-id "VERSION_ID" --platform IOS --strict` ## Actual Behavior ``` │ warning │ metadata.required.whats_new │ en-US │ whatsNew │ ... │ what's new is empty │ Provide release notes for this localization │ ``` With `--strict`, this causes a non-zero exit code. ## Expected Behavior The `validate` command should skip the `whatsNew` check for initial releases (v1.0), since Apple does not allow setting it. ## Notes The `localizations upload` command already handles this correctly — when uploading with a `whatsNew` value on a v1.0 release, it prints: ``` Warning: 'whatsNew' cannot be set for this version (initial releases have no What's New section). Retrying without it. ``` So the awareness is already there in the upload path, just not in the validate path.
kerem closed this issue 2026-02-26 21:33:48 +03:00
kerem commented 2026-02-26 21:33:49 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 15, 2026):

Yeah oops. I had made it optional for the exact reason but should do better handling

<!-- gh-comment-id:3904707766 --> @rudrankriyam commented on GitHub (Feb 15, 2026): Yeah oops. I had made it optional for the exact reason but should do better handling
kerem commented 2026-02-26 21:33:49 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 15, 2026):

@cursor please fix this and add any relevant tests

<!-- gh-comment-id:3904708533 --> @rudrankriyam commented on GitHub (Feb 15, 2026): @cursor please fix this and add any relevant tests
kerem commented 2026-02-26 21:33:49 +03:00
Author
Owner
Copy link

@cursor[bot] commented on GitHub (Feb 15, 2026):

I fixed asc validate so it does not warn about an empty whatsNew on initial releases (detected via versionString being 1.0, 1.0.0, etc.). This prevents --strict from failing solely due to the “What’s New is empty” warning on first submissions.

Tests added:

  • internal/validation/required_fields_test.go: asserts metadata.required.whats_new is skipped for 1.0 and still warns for update versions like 1.0.1.
  • internal/cli/cmdtest/validate_test.go: regression test that asc validate --strict succeeds for a v1.0 version localization with missing/empty whatsNew.

Verification I ran:

  • make format
  • make lint
  • ASC_BYPASS_KEYCHAIN=1 make test
  • ASC_BYPASS_KEYCHAIN=1 go test -v ./internal/cli/cmdtest -run TestValidateSkipsWhatsNewOnInitialRelease

Changes are committed and pushed to cursor/v1-0-whatsnew-validation-17f2.

View PR

Open in Cursor Open in Web

<!-- gh-comment-id:3904708892 --> @cursor[bot] commented on GitHub (Feb 15, 2026): I fixed `asc validate` so it **does not warn about an empty `whatsNew` on initial releases** (detected via `versionString` being `1.0`, `1.0.0`, etc.). This prevents `--strict` from failing solely due to the “What’s New is empty” warning on first submissions. Tests added: - `internal/validation/required_fields_test.go`: asserts `metadata.required.whats_new` is **skipped** for `1.0` and still **warns** for update versions like `1.0.1`. - `internal/cli/cmdtest/validate_test.go`: regression test that `asc validate --strict` **succeeds** for a v1.0 version localization with missing/empty `whatsNew`. Verification I ran: - `make format` - `make lint` - `ASC_BYPASS_KEYCHAIN=1 make test` - `ASC_BYPASS_KEYCHAIN=1 go test -v ./internal/cli/cmdtest -run TestValidateSkipsWhatsNewOnInitialRelease` Changes are committed and pushed to `cursor/v1-0-whatsnew-validation-17f2`. <p><a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/556"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a></p> <p><a href="https://cursor.com/background-agent?bcId=bc-6c563ad8-8f4b-4f1f-9f1b-954c2742ecd5"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-6c563ad8-8f4b-4f1f-9f1b-954c2742ecd5"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p>
kerem commented 2026-02-26 21:33:49 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 15, 2026):

Resolved by #556 (merged). asc validate now skips the empty whatsNew warning on initial 1.0 releases so --strict does not fail solely for that.

<!-- gh-comment-id:3904737654 --> @rudrankriyam commented on GitHub (Feb 15, 2026): Resolved by #556 (merged). `asc validate` now skips the empty `whatsNew` warning on initial 1.0 releases so `--strict` does not fail solely for that.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.1
1.0.0
0.49.1
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.2
0.46.1
0.46.0
0.45.4
0.45.3
0.45.2
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.0
0.42.0
0.41.4
0.41.3
0.41.2
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.3
0.38.2
0.38.1
0.38.0
0.37.3
0.37.2
0.37.1
0.37.0
0.36.3
0.36.2
0.36.1
0.36.0
0.35.3
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.2
0.33.1
0.33.0
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.3
0.29.2
0.29.1
0.29.0
0.28.14
0.28.13
0.28.12
0.28.11
0.28.10
0.28.9
0.28.8
0.28.7
0.28.6
0.28.5
0.28.4
0.28.3
0.28.2
0.28.1
0.28.0
0.27.0
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.4
0.25.3
0.25.1
0.25.0
0.24.3
0.24.2
0.24.1
0.24.0
0.23.5
0.23.4
0.23.3
0.23.2
0.23.1
0.23.0
0.22.1
0.22.0
0.21.0
0.20.2
0.20.1
0.20.0
0.19.3
0.19.2
0.19.1
0.19.0
0.18.2
0.18.1
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.4
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.2
0.10.1
0.10.0
0.9.0
0.8.1
0.8.0
0.7.0
0.6.0
0.5.0
0.3.1
0.3.0
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

   
bug

   
documentation

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
documentation
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#151
No description provided.