starred/App-Store-Connect-CLI
1
0
Fork 0
mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 07:35:48 +03:00
Code Issues 2 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #468] Parity: Bundle ID capability update endpoint (PATCH) #130

New issue
Closed
opened 2026-02-26 21:33:40 +03:00 by kerem · 3 comments
kerem commented 2026-02-26 21:33:40 +03:00
Owner
Copy link

Originally created by @rudrankriyam on GitHub (Feb 10, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/468

Overview

Add parity support for updating an existing bundle ID capability.

Scope (OpenAPI resources)

  • PATCH /v1/bundleIdCapabilities/{id}

Current state

Current capability support includes:

  • list capabilities for a bundle ID
  • create capability
  • delete capability

Update/patch for an existing capability is still missing.

Proposed CLI

Add a dedicated update command:

  • asc bundle-ids capabilities update --id "CAPABILITY_ID" --settings '[{"key":"ICLOUD_VERSION","options":[{"key":"XCODE_13","enabled":true}]}]'

Optional (if API schema supports it safely):

  • --capability for capability type updates

Examples:

  • asc bundle-ids capabilities update --id "CAPABILITY_ID" --settings '[{"key":"ICLOUD_VERSION","options":[{"key":"XCODE_13","enabled":true}]}]'
  • asc bundle-ids capabilities update --id "CAPABILITY_ID" --output table

Flag patterns

Common: --id, --settings, --output, --pretty

Validation rules:

  • --id is required
  • At least one update field is required
  • --settings must be valid JSON array

Detailed TODO

  • Add update request/attribute types for bundle ID capabilities in internal/asc/signing.go.
  • Add client method in internal/asc/client_signing.go:
    • UpdateBundleIDCapability(ctx, capabilityID, attrs) -> PATCH /v1/bundleIdCapabilities/{id}
  • Add CLI subcommand in internal/cli/bundleids/bundle_ids_capabilities.go:
    • BundleIDsCapabilitiesUpdateCommand()
  • Reuse/extend existing JSON settings parsing helper for update payload validation.
  • Wire command into the capabilities command group and help output.

Acceptance criteria

  • Existing bundle ID capability can be patched by ID.
  • Invalid JSON settings fail with clear usage error.
  • Missing update fields fail with clear usage error.
  • make format, make lint, and make test pass.

Tests

  • HTTP client test for PATCH /v1/bundleIdCapabilities/{id} with payload assertion.
  • cmdtests for required --id validation.
  • cmdtests for invalid --settings JSON.
  • cmdtests for success path and output handling.

Implementation notes

  • Follow existing certificate update pattern (PATCH) for structure and tests.
  • Keep behavior explicit and non-interactive.

References

  • docs/openapi/paths.txt
  • docs/openapi/latest.json
  • internal/asc/client_signing.go
  • internal/asc/signing.go
  • internal/cli/bundleids/bundle_ids_capabilities.go
Originally created by @rudrankriyam on GitHub (Feb 10, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/468 # Overview Add parity support for updating an existing bundle ID capability. # Scope (OpenAPI resources) - `PATCH /v1/bundleIdCapabilities/{id}` # Current state Current capability support includes: - list capabilities for a bundle ID - create capability - delete capability Update/patch for an existing capability is still missing. # Proposed CLI Add a dedicated update command: - `asc bundle-ids capabilities update --id "CAPABILITY_ID" --settings '[{"key":"ICLOUD_VERSION","options":[{"key":"XCODE_13","enabled":true}]}]'` Optional (if API schema supports it safely): - `--capability` for capability type updates Examples: - `asc bundle-ids capabilities update --id "CAPABILITY_ID" --settings '[{"key":"ICLOUD_VERSION","options":[{"key":"XCODE_13","enabled":true}]}]'` - `asc bundle-ids capabilities update --id "CAPABILITY_ID" --output table` # Flag patterns Common: `--id`, `--settings`, `--output`, `--pretty` Validation rules: - `--id` is required - At least one update field is required - `--settings` must be valid JSON array # Detailed TODO - [ ] Add update request/attribute types for bundle ID capabilities in `internal/asc/signing.go`. - [ ] Add client method in `internal/asc/client_signing.go`: - [ ] `UpdateBundleIDCapability(ctx, capabilityID, attrs)` -> `PATCH /v1/bundleIdCapabilities/{id}` - [ ] Add CLI subcommand in `internal/cli/bundleids/bundle_ids_capabilities.go`: - [ ] `BundleIDsCapabilitiesUpdateCommand()` - [ ] Reuse/extend existing JSON settings parsing helper for update payload validation. - [ ] Wire command into the capabilities command group and help output. # Acceptance criteria - [ ] Existing bundle ID capability can be patched by ID. - [ ] Invalid JSON settings fail with clear usage error. - [ ] Missing update fields fail with clear usage error. - [ ] `make format`, `make lint`, and `make test` pass. # Tests - [ ] HTTP client test for `PATCH /v1/bundleIdCapabilities/{id}` with payload assertion. - [ ] cmdtests for required `--id` validation. - [ ] cmdtests for invalid `--settings` JSON. - [ ] cmdtests for success path and output handling. # Implementation notes - Follow existing certificate update pattern (`PATCH`) for structure and tests. - Keep behavior explicit and non-interactive. # References - `docs/openapi/paths.txt` - `docs/openapi/latest.json` - `internal/asc/client_signing.go` - `internal/asc/signing.go` - `internal/cli/bundleids/bundle_ids_capabilities.go`
kerem closed this issue 2026-02-26 21:33:40 +03:00
kerem commented 2026-02-26 21:33:40 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 10, 2026):

@cursor Please implement this issue end-to-end.

What to build

Add update support for existing bundle ID capabilities.

Endpoint to add

  • PATCH /v1/bundleIdCapabilities/{id}

Implementation plan

  1. Types (internal/asc/signing.go)
  • Add update request types for bundle ID capabilities:
    • update attributes
    • update data envelope
    • update request envelope
  • Keep payload sparse (only explicitly set fields).
  1. Client (internal/asc/client_signing.go)
  • Add method:
    • UpdateBundleIDCapability(ctx, capabilityID, attrs)
  • Use path: /v1/bundleIdCapabilities/{id}
  • Return parsed BundleIDCapabilityResponse.
  1. CLI (internal/cli/bundleids/bundle_ids_capabilities.go)
  • Add subcommand:
    • asc bundle-ids capabilities update --id "CAPABILITY_ID" --settings 'JSON'
  • Reuse JSON settings parser used by create path.
  • Validation:
    • --id required
    • at least one update field required
    • invalid --settings JSON should return usage error (exit code 2)
  • Wire into BundleIDsCapabilitiesCommand() subcommands list.

New tests to write

A) Client HTTP tests (internal/asc/client_http_test.go)

  • TestUpdateBundleIDCapability_UsesPatchPath
    • assert method PATCH
    • assert path /v1/bundleIdCapabilities/{id}
    • assert request body type is bundleIdCapabilities
    • assert settings payload shape

B) CLI cmdtests (new file)

  • internal/cli/cmdtest/bundle_ids_capabilities_update_test.go

Add test cases:

  • missing --id -> usage error
  • no update fields -> usage error
  • invalid --settings JSON -> usage error
  • success path -> returns updated resource output

C) Command/help coverage

  • Ensure command appears under asc bundle-ids capabilities --help output and has examples.

How to test locally

Run exactly:

  • make format
  • make lint
  • make test

Targeted tests:

  • go test ./internal/asc -run UpdateBundleIDCapability
  • go test ./internal/cli/cmdtest -run BundleID.*Capabilities.*Update

Done criteria

  • Patch endpoint is reachable via CLI update command.
  • Validation and output behavior are covered by cmdtests.
  • All checks pass (format, lint, test).
<!-- gh-comment-id:3877922530 --> @rudrankriyam commented on GitHub (Feb 10, 2026): @cursor Please implement this issue end-to-end. ## What to build Add update support for existing bundle ID capabilities. ### Endpoint to add - `PATCH /v1/bundleIdCapabilities/{id}` ## Implementation plan 1. **Types (`internal/asc/signing.go`)** - Add update request types for bundle ID capabilities: - update attributes - update data envelope - update request envelope - Keep payload sparse (only explicitly set fields). 2. **Client (`internal/asc/client_signing.go`)** - Add method: - `UpdateBundleIDCapability(ctx, capabilityID, attrs)` - Use path: `/v1/bundleIdCapabilities/{id}` - Return parsed `BundleIDCapabilityResponse`. 3. **CLI (`internal/cli/bundleids/bundle_ids_capabilities.go`)** - Add subcommand: - `asc bundle-ids capabilities update --id "CAPABILITY_ID" --settings 'JSON'` - Reuse JSON settings parser used by create path. - Validation: - `--id` required - at least one update field required - invalid `--settings` JSON should return usage error (exit code 2) - Wire into `BundleIDsCapabilitiesCommand()` subcommands list. ## New tests to write ### A) Client HTTP tests (`internal/asc/client_http_test.go`) - `TestUpdateBundleIDCapability_UsesPatchPath` - assert method `PATCH` - assert path `/v1/bundleIdCapabilities/{id}` - assert request body type is `bundleIdCapabilities` - assert settings payload shape ### B) CLI cmdtests (new file) - `internal/cli/cmdtest/bundle_ids_capabilities_update_test.go` Add test cases: - missing `--id` -> usage error - no update fields -> usage error - invalid `--settings` JSON -> usage error - success path -> returns updated resource output ### C) Command/help coverage - Ensure command appears under `asc bundle-ids capabilities --help` output and has examples. ## How to test locally Run exactly: - `make format` - `make lint` - `make test` Targeted tests: - `go test ./internal/asc -run UpdateBundleIDCapability` - `go test ./internal/cli/cmdtest -run BundleID.*Capabilities.*Update` ## Done criteria - Patch endpoint is reachable via CLI update command. - Validation and output behavior are covered by cmdtests. - All checks pass (`format`, `lint`, `test`).
kerem commented 2026-02-26 21:33:41 +03:00
Author
Owner
Copy link

@cursor[bot] commented on GitHub (Feb 10, 2026):

Implementation is complete. Here's a summary of what was done:

Types (internal/asc/signing.go):

  • Added BundleIDCapabilityUpdateAttributes with capabilityType and settings fields (both omitempty for sparse payloads)
  • Added BundleIDCapabilityUpdateData envelope with type, ID, and optional attributes
  • Added BundleIDCapabilityUpdateRequest wrapper

Client (internal/asc/client_signing.go):

  • Added UpdateBundleIDCapability(ctx, capabilityID, attrs) method using PATCH /v1/bundleIdCapabilities/{id}, returning *BundleIDCapabilityResponse

CLI (internal/cli/bundleids/bundle_ids_capabilities.go):

  • Added BundleIDsCapabilitiesUpdateCommand() with flags: --id, --capability, --settings, --output, --pretty
  • Validation: --id required, at least one update field required (--capability or --settings), invalid --settings JSON returns usage error (exit code 2)
  • Wired into BundleIDsCapabilitiesCommand() subcommands and updated help examples

Tests:

  • Client HTTP test: TestUpdateBundleIDCapability_UsesPatchPath - asserts PATCH method, correct path, request body type/shape, and settings payload
  • CLI cmdtests (5 tests): missing --id, no update fields, invalid settings JSON, success path with settings, success path with capability type

Verification: make format, make lint, and make test all pass.

View PR

Open in Cursor Open in Web

<!-- gh-comment-id:3877923129 --> @cursor[bot] commented on GitHub (Feb 10, 2026): Implementation is complete. Here's a summary of what was done: **Types** (`internal/asc/signing.go`): - Added `BundleIDCapabilityUpdateAttributes` with `capabilityType` and `settings` fields (both `omitempty` for sparse payloads) - Added `BundleIDCapabilityUpdateData` envelope with type, ID, and optional attributes - Added `BundleIDCapabilityUpdateRequest` wrapper **Client** (`internal/asc/client_signing.go`): - Added `UpdateBundleIDCapability(ctx, capabilityID, attrs)` method using `PATCH /v1/bundleIdCapabilities/{id}`, returning `*BundleIDCapabilityResponse` **CLI** (`internal/cli/bundleids/bundle_ids_capabilities.go`): - Added `BundleIDsCapabilitiesUpdateCommand()` with flags: `--id`, `--capability`, `--settings`, `--output`, `--pretty` - Validation: `--id` required, at least one update field required (`--capability` or `--settings`), invalid `--settings` JSON returns usage error (exit code 2) - Wired into `BundleIDsCapabilitiesCommand()` subcommands and updated help examples **Tests**: - **Client HTTP test**: `TestUpdateBundleIDCapability_UsesPatchPath` - asserts PATCH method, correct path, request body type/shape, and settings payload - **CLI cmdtests** (5 tests): missing `--id`, no update fields, invalid settings JSON, success path with settings, success path with capability type **Verification**: `make format`, `make lint`, and `make test` all pass. <p><a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/471"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a></p> <p><a href="https://cursor.com/background-agent?bcId=bc-2c105ec0-3a0f-4ac3-872e-64feed0d5356"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-2c105ec0-3a0f-4ac3-872e-64feed0d5356"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a></p>
kerem commented 2026-02-26 21:33:41 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 10, 2026):

Implemented and merged in #471.
Bundle ID capability PATCH parity is now covered in client and CLI, with audit fixes and tests.
Closing as complete.

<!-- gh-comment-id:3878644711 --> @rudrankriyam commented on GitHub (Feb 10, 2026): Implemented and merged in #471. Bundle ID capability PATCH parity is now covered in client and CLI, with audit fixes and tests. Closing as complete.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.1
1.0.0
0.49.1
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.2
0.46.1
0.46.0
0.45.4
0.45.3
0.45.2
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.0
0.42.0
0.41.4
0.41.3
0.41.2
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.3
0.38.2
0.38.1
0.38.0
0.37.3
0.37.2
0.37.1
0.37.0
0.36.3
0.36.2
0.36.1
0.36.0
0.35.3
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.2
0.33.1
0.33.0
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.3
0.29.2
0.29.1
0.29.0
0.28.14
0.28.13
0.28.12
0.28.11
0.28.10
0.28.9
0.28.8
0.28.7
0.28.6
0.28.5
0.28.4
0.28.3
0.28.2
0.28.1
0.28.0
0.27.0
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.4
0.25.3
0.25.1
0.25.0
0.24.3
0.24.2
0.24.1
0.24.0
0.23.5
0.23.4
0.23.3
0.23.2
0.23.1
0.23.0
0.22.1
0.22.0
0.21.0
0.20.2
0.20.1
0.20.0
0.19.3
0.19.2
0.19.1
0.19.0
0.18.2
0.18.1
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.4
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.2
0.10.1
0.10.0
0.9.0
0.8.1
0.8.0
0.7.0
0.6.0
0.5.0
0.3.1
0.3.0
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

   
bug

   
documentation

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
documentation
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#130
No description provided.