[PR #358] [MERGED] Fix subscription offer code price payload #468

New issue

Closed

opened 2026-02-26 22:31:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/358
Author: @rudrankriyam
Created: 1/31/2026
Status: ✅ Merged
Merged: 1/31/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/subscription-offer-code-inline-prices

📝 Commits (1)

d9d99ce Fix subscription offer code price payload.

📊 Changes

7 files changed (+135 additions, -23 deletions)

View changed files

📝 internal/asc/client_subscription_resources.go (+35 -7)
📝 internal/asc/subscription_resources.go (+7 -1)
📝 internal/asc/subscriptions_resources_http_test.go (+17 -2)
📝 internal/cli/offercodes/offer_codes.go (+1 -1)
📝 internal/cli/offercodes/subscription_offer_codes.go (+40 -6)
📝 internal/cli/subscriptions/helpers.go (+26 -1)
📝 internal/cli/subscriptions/offer_codes.go (+9 -5)

📄 Description

Summary

include inline price relationships when creating subscription offer codes
accept TERRITORY:PRICE_POINT_ID inputs for offer-code create commands (deprecated --price-id fallback)
update tests and examples to match the new price format

Test plan

make build
make lint
make test
asc offer-codes create --subscription-id "6670453472" --prices "USA:PRICE_POINT_ID" (plus get/prices/update)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/358 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/31/2026 **Status:** ✅ Merged **Merged:** 1/31/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/subscription-offer-code-inline-prices` --- ### 📝 Commits (1) - [`d9d99ce`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d9d99cef3dac143d491d79d3b41726a6d3a5b2e2) Fix subscription offer code price payload. ### 📊 Changes **7 files changed** (+135 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_subscription_resources.go` (+35 -7) 📝 `internal/asc/subscription_resources.go` (+7 -1) 📝 `internal/asc/subscriptions_resources_http_test.go` (+17 -2) 📝 `internal/cli/offercodes/offer_codes.go` (+1 -1) 📝 `internal/cli/offercodes/subscription_offer_codes.go` (+40 -6) 📝 `internal/cli/subscriptions/helpers.go` (+26 -1) 📝 `internal/cli/subscriptions/offer_codes.go` (+9 -5) </details> ### 📄 Description ## Summary - include inline price relationships when creating subscription offer codes - accept TERRITORY:PRICE_POINT_ID inputs for offer-code create commands (deprecated --price-id fallback) - update tests and examples to match the new price format ## Test plan - [x] make build - [x] make lint - [x] make test - [x] asc offer-codes create --subscription-id "6670453472" --prices "USA:PRICE_POINT_ID" (plus get/prices/update) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>