starred/App-Store-Connect-CLI

Fork

You've already forked App-Store-Connect-CLI

mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 07:35:48 +03:00

Code Issues 2 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #412] Parity: TestFlight missing endpoints (feedback delete, tester relationships, review list) #120

New issue

Closed

opened 2026-02-26 21:33:33 +03:00 by kerem · 3 comments

kerem commented

2026-02-26 21:33:33 +03:00

Owner

Copy link

Originally created by @rudrankriyam on GitHub (Feb 2, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/412

Overview

Fill remaining TestFlight parity gaps: feedback submission deletion, beta tester relationship management (apps/builds), beta app review submissions list, and recruitment criteria delete.

Scope (OpenAPI resources)

Completely Missing (no client, no CLI)

DELETE /v1/betaFeedbackCrashSubmissions/{id}
DELETE /v1/betaFeedbackScreenshotSubmissions/{id}
DELETE /v1/betaTesters/{id}/relationships/apps
DELETE /v1/betaTesters/{id}/relationships/builds
POST /v1/betaTesters/{id}/relationships/builds
DELETE /v1/apps/{id}/relationships/betaTesters

Client exists, needs CLI

GET /v1/betaAppReviewSubmissions (LIST) - client: GetBetaAppReviewSubmissions
DELETE /v1/betaRecruitmentCriteria/{id} - client: DeleteBetaRecruitmentCriteria

Proposed CLI

Feedback deletion

asc testflight beta-feedback crash-submissions delete --id "SUBMISSION_ID" --confirm
asc testflight beta-feedback screenshot-submissions delete --id "SUBMISSION_ID" --confirm

Beta tester relationships

asc testflight beta-testers remove-apps --id "TESTER_ID" --app "APP_ID[,APP_ID...]" --confirm
asc testflight beta-testers add-builds --id "TESTER_ID" --build "BUILD_ID[,BUILD_ID...]"
asc testflight beta-testers remove-builds --id "TESTER_ID" --build "BUILD_ID[,BUILD_ID...]" --confirm

App-level tester removal

asc apps remove-beta-testers --app "APP_ID" --tester "TESTER_ID[,TESTER_ID...]" --confirm

Review submissions list (client exists)

asc testflight review submissions list [--build "BUILD_ID"] [--limit N] [--paginate]

Recruitment criteria delete (client exists)

asc testflight recruitment delete --id "CRITERIA_ID" --confirm

Flag patterns

Common: --id, --app, --build, --tester, --output, --pretty, --limit, --next, --paginate, --confirm

Output

JSON minified by default
--pretty for JSON
--output table/markdown for list commands

Detailed TODO

Add client methods: DeleteBetaFeedbackCrashSubmission, DeleteBetaFeedbackScreenshotSubmission
Add client methods: RemoveBetaTesterFromApps, AddBuildsToBetaTester, RemoveBuildsFromBetaTester
Add client method: RemoveBetaTestersFromApp
Add testflight beta-feedback crash-submissions delete subcommand
Add testflight beta-feedback screenshot-submissions delete subcommand
Add testflight beta-testers remove-apps subcommand
Add testflight beta-testers add-builds subcommand
Add testflight beta-testers remove-builds subcommand
Add apps remove-beta-testers subcommand
Add testflight review submissions list subcommand (wire existing client)
Add testflight recruitment delete subcommand (wire existing client)
Add HTTP client tests (mocked)
Add CLI cmdtests for flag validation + output

Acceptance criteria

Beta feedback submissions can be deleted
Beta testers can have apps/builds added/removed
Beta testers can be removed from apps
Beta app review submissions can be listed with filtering
Recruitment criteria can be deleted

Tests

Flag validation tests for each new command
HTTP client tests for each new endpoint
Confirm flag required for destructive operations

Implementation notes

Follow existing patterns in internal/cli/testflight/beta_feedback.go for delete commands
Follow existing add-groups/remove-groups pattern for relationship commands
--confirm required for all DELETE operations
Two commands just need CLI wiring (client already exists)

References

docs/openapi/paths.txt
docs/openapi/latest.json
internal/asc/client_beta_feedback.go
internal/asc/client_testflight_review.go

Originally created by @rudrankriyam on GitHub (Feb 2, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/412 # Overview Fill remaining TestFlight parity gaps: feedback submission deletion, beta tester relationship management (apps/builds), beta app review submissions list, and recruitment criteria delete. # Scope (OpenAPI resources) ## Completely Missing (no client, no CLI) - `DELETE /v1/betaFeedbackCrashSubmissions/{id}` - `DELETE /v1/betaFeedbackScreenshotSubmissions/{id}` - `DELETE /v1/betaTesters/{id}/relationships/apps` - `DELETE /v1/betaTesters/{id}/relationships/builds` - `POST /v1/betaTesters/{id}/relationships/builds` - `DELETE /v1/apps/{id}/relationships/betaTesters` ## Client exists, needs CLI - `GET /v1/betaAppReviewSubmissions` (LIST) - client: `GetBetaAppReviewSubmissions` - `DELETE /v1/betaRecruitmentCriteria/{id}` - client: `DeleteBetaRecruitmentCriteria` # Proposed CLI ## Feedback deletion - `asc testflight beta-feedback crash-submissions delete --id "SUBMISSION_ID" --confirm` - `asc testflight beta-feedback screenshot-submissions delete --id "SUBMISSION_ID" --confirm` ## Beta tester relationships - `asc testflight beta-testers remove-apps --id "TESTER_ID" --app "APP_ID[,APP_ID...]" --confirm` - `asc testflight beta-testers add-builds --id "TESTER_ID" --build "BUILD_ID[,BUILD_ID...]"` - `asc testflight beta-testers remove-builds --id "TESTER_ID" --build "BUILD_ID[,BUILD_ID...]" --confirm` ## App-level tester removal - `asc apps remove-beta-testers --app "APP_ID" --tester "TESTER_ID[,TESTER_ID...]" --confirm` ## Review submissions list (client exists) - `asc testflight review submissions list [--build "BUILD_ID"] [--limit N] [--paginate]` ## Recruitment criteria delete (client exists) - `asc testflight recruitment delete --id "CRITERIA_ID" --confirm` # Flag patterns Common: `--id`, `--app`, `--build`, `--tester`, `--output`, `--pretty`, `--limit`, `--next`, `--paginate`, `--confirm` # Output - JSON minified by default - `--pretty` for JSON - `--output table/markdown` for list commands # Detailed TODO - [ ] Add client methods: `DeleteBetaFeedbackCrashSubmission`, `DeleteBetaFeedbackScreenshotSubmission` - [ ] Add client methods: `RemoveBetaTesterFromApps`, `AddBuildsToBetaTester`, `RemoveBuildsFromBetaTester` - [ ] Add client method: `RemoveBetaTestersFromApp` - [ ] Add `testflight beta-feedback crash-submissions delete` subcommand - [ ] Add `testflight beta-feedback screenshot-submissions delete` subcommand - [ ] Add `testflight beta-testers remove-apps` subcommand - [ ] Add `testflight beta-testers add-builds` subcommand - [ ] Add `testflight beta-testers remove-builds` subcommand - [ ] Add `apps remove-beta-testers` subcommand - [ ] Add `testflight review submissions list` subcommand (wire existing client) - [ ] Add `testflight recruitment delete` subcommand (wire existing client) - [ ] Add HTTP client tests (mocked) - [ ] Add CLI cmdtests for flag validation + output # Acceptance criteria - [ ] Beta feedback submissions can be deleted - [ ] Beta testers can have apps/builds added/removed - [ ] Beta testers can be removed from apps - [ ] Beta app review submissions can be listed with filtering - [ ] Recruitment criteria can be deleted # Tests - Flag validation tests for each new command - HTTP client tests for each new endpoint - Confirm flag required for destructive operations # Implementation notes - Follow existing patterns in `internal/cli/testflight/beta_feedback.go` for delete commands - Follow existing `add-groups`/`remove-groups` pattern for relationship commands - `--confirm` required for all DELETE operations - Two commands just need CLI wiring (client already exists) # References - `docs/openapi/paths.txt` - `docs/openapi/latest.json` - `internal/asc/client_beta_feedback.go` - `internal/asc/client_testflight_review.go`

kerem closed this issue

2026-02-26 21:33:34 +03:00

kerem commented

2026-02-26 21:33:34 +03:00

Author

Owner

Copy link

@rudrankriyam commented on GitHub (Feb 2, 2026):

@cursor please implement this issue. Start with the two easy wins that just need CLI wiring (review submissions list and recruitment delete), then implement the client methods and CLI commands for the remaining endpoints.

@rudrankriyam commented on GitHub (Feb 2, 2026): @cursor please implement this issue. Start with the two easy wins that just need CLI wiring (review submissions list and recruitment delete), then implement the client methods and CLI commands for the remaining endpoints.

kerem commented

2026-02-26 21:33:35 +03:00

Author

Owner

Copy link

@cursor[bot] commented on GitHub (Feb 2, 2026):

Summary:

I wired the “easy wins” (TestFlight review submissions list + recruitment delete) and added pagination support, then added the remaining TestFlight/app beta feedback/tester relationship commands with new output result types.
I implemented the missing ASC client methods and HTTP tests, plus CLI cmdtests for flag validation and output across the new commands.

Testing:

make test
go test ./internal/cli/cmdtest -run 'TestTestFlightReviewSubmissionsListOutputTable|TestTestFlightBetaFeedbackCrashSubmissionsDeleteOutput|TestAppsRemoveBetaTestersOutput' -v (recorded in the video)

Walkthrough artifact:

testflight_cmdtests_demo_zoomed/recording_demo.mp4 shows the targeted cmdtests passing for the new review submissions list, beta feedback delete, and apps remove-beta-testers commands.

@cursor[bot] commented on GitHub (Feb 2, 2026): Summary: - I wired the “easy wins” (TestFlight review submissions list + recruitment delete) and added pagination support, then added the remaining TestFlight/app beta feedback/tester relationship commands with new output result types. - I implemented the missing ASC client methods and HTTP tests, plus CLI cmdtests for flag validation and output across the new commands. Testing: - `make test` - `go test ./internal/cli/cmdtest -run 'TestTestFlightReviewSubmissionsListOutputTable|TestTestFlightBetaFeedbackCrashSubmissionsDeleteOutput|TestAppsRemoveBetaTestersOutput' -v` (recorded in the video) Walkthrough artifact: - `testflight_cmdtests_demo_zoomed/recording_demo.mp4` shows the targeted cmdtests passing for the new review submissions list, beta feedback delete, and apps remove-beta-testers commands. <a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/416"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-d70e60d3-e343-470d-b2ff-452bb4342994"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-d70e60d3-e343-470d-b2ff-452bb4342994"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>

kerem commented

2026-02-26 21:33:35 +03:00

Author

Owner

Copy link

@rudrankriyam commented on GitHub (Feb 3, 2026):

Resolved in #416 (additional coverage in #420).

@rudrankriyam commented on GitHub (Feb 3, 2026): Resolved in #416 (additional coverage in #420).

kerem referenced this issue

2026-02-26 21:34:29 +03:00

[PR #120] [MERGED] Client subscriptions cleanup #300

kerem referenced this issue

2026-02-26 21:34:29 +03:00

[PR #118] [MERGED] In-app purchases and subscriptions #301

No Branch/Tag specified

main

1.2.6

1.2.5

1.2.4

1.2.3

1.2.2

1.2.1

1.2.0

1.1.1

1.1.0

1.0.1

1.0.0

0.49.1

0.49.0

0.48.1

0.48.0

0.47.1

0.47.0

0.46.2

0.46.1

0.46.0

0.45.4

0.45.3

0.45.2

0.45.1

0.45.0

0.44.2

0.44.1

0.44.0

0.43.0

0.42.0

0.41.4

0.41.3

0.41.2

0.41.1

0.41.0

0.40.1

0.40.0

0.39.1

0.39.0

0.38.3

0.38.2

0.38.1

0.38.0

0.37.3

0.37.2

0.37.1

0.37.0

0.36.3

0.36.2

0.36.1

0.36.0

0.35.3

0.35.2

0.35.1

0.35.0

0.34.1

0.34.0

0.33.2

0.33.1

0.33.0

0.32.0

0.31.3

0.31.2

0.31.1

0.31.0

0.30.0

0.29.3

0.29.2

0.29.1

0.29.0

0.28.14

0.28.13

0.28.12

0.28.11

0.28.10

0.28.9

0.28.8

0.28.7

0.28.6

0.28.5

0.28.4

0.28.3

0.28.2

0.28.1

0.28.0

0.27.0

0.26.4

0.26.3

0.26.2

0.26.1

0.26.0

0.25.4

0.25.3

0.25.1

0.25.0

0.24.3

0.24.2

0.24.1

0.24.0

0.23.5

0.23.4

0.23.3

0.23.2

0.23.1

0.23.0

0.22.1

0.22.0

0.21.0

0.20.2

0.20.1

0.20.0

0.19.3

0.19.2

0.19.1

0.19.0

0.18.2

0.18.1

0.18.0

0.17.0

0.16.0

0.15.0

0.14.0

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.0

0.10.2

0.10.1

0.10.0

0.9.0

0.8.1

0.8.0

0.7.0

0.6.0

0.5.0

0.3.1

0.3.0

0.2.0

0.1.6

0.1.5

0.1.4

0.1.3

0.1.2

0.1.1

0.1.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/App-Store-Connect-CLI#120

Reference in a new issue

Repository

starred/App-Store-Connect-CLI

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns