starred/App-Store-Connect-CLI
1
0
Fork 0
mirror of https://github.com/rudrankriyam/App-Store-Connect-CLI.git synced 2026-04-25 15:45:48 +03:00
Code Issues 2 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #398] Please expose subscription period + grace period #112

New issue
Closed
opened 2026-02-26 21:33:30 +03:00 by kerem · 4 comments
kerem commented 2026-02-26 21:33:30 +03:00
Owner
Copy link

Originally created by @flutterrausch on GitHub (Feb 2, 2026).
Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/398

Sorry for not making a PR myself - never did one, no time RN. Hope this is good enough :)

The **API supports subscription period **, but the CLI doesn't expose it as a flag.

What the App Store Connect API actually supports

Looking at the internal structs in asc:

// SubscriptionCreateAttributes describes attributes for creating a subscription.
type SubscriptionCreateAttributes struct {
    Name                      string  `json:"name"`
    ProductID                 string  `json:"productId"`
    FamilySharable            *bool   `json:"familySharable,omitempty"`
    SubscriptionPeriod        string  `json:"subscriptionPeriod,omitempty"`  // <-- EXISTS
    ReviewNote                string  `json:"reviewNote,omitempty"`
    GroupLevel                *int    `json:"groupLevel,omitempty"`
    AvailableInAllTerritories *bool   `json:"availableInAllTerritories,omitempty"`
}

The SubscriptionPeriod field is there for create and update. Valid values (per Apple's API docs) are:

  • ONE_WEEK
  • ONE_MONTH
  • TWO_MONTHS
  • THREE_MONTHS
  • SIX_MONTHS
  • ONE_YEAR

Why the CLI doesn't expose it

The CLI command (asc subscriptions create) only wires up these flags:

--group        Subscription group ID
--product-id   Product ID (e.g., com.example.sub)
--ref-name     Reference name

The Go code passes Name and ProductID to the API, but never sets SubscriptionPeriod even though the struct supports it. This is simply an incomplete CLI implementation.

What you CAN set up with asc today

Feature asc support
Subscription groups create, list, get, update, delete
Subscriptions create (no period), list, get, update (no period), delete
Subscription period not exposed (API supports it)
Prices per territory add, list, delete
Price points & equalizations list, query
Localizations (name/description) create, update, delete
Introductory offers (trials) create, update, delete
Review screenshots upload, update, delete
Promotional offers create, update, delete
Availability set territories
Grace period read-only

Options to fix this

expose --subscription-period on subscriptions create and subscriptions update. It's a small change (add the flag and wire it to the struct).

Grace period

Same thing I think, fixed to 14d would be alright.

Originally created by @flutterrausch on GitHub (Feb 2, 2026). Original GitHub issue: https://github.com/rudrankriyam/App-Store-Connect-CLI/issues/398 Sorry for not making a PR myself - never did one, no time RN. Hope this is good enough :) The **API supports subscription period **, but the **CLI doesn't expose it as a flag**. ## What the App Store Connect API actually supports Looking at the internal structs in `asc`: ```go // SubscriptionCreateAttributes describes attributes for creating a subscription. type SubscriptionCreateAttributes struct { Name string `json:"name"` ProductID string `json:"productId"` FamilySharable *bool `json:"familySharable,omitempty"` SubscriptionPeriod string `json:"subscriptionPeriod,omitempty"` // <-- EXISTS ReviewNote string `json:"reviewNote,omitempty"` GroupLevel *int `json:"groupLevel,omitempty"` AvailableInAllTerritories *bool `json:"availableInAllTerritories,omitempty"` } ``` The `SubscriptionPeriod` field is there for create and update. Valid values (per Apple's API docs) are: - `ONE_WEEK` - `ONE_MONTH` - `TWO_MONTHS` - `THREE_MONTHS` - `SIX_MONTHS` - `ONE_YEAR` ## Why the CLI doesn't expose it The CLI command (`asc subscriptions create`) only wires up these flags: ``` --group Subscription group ID --product-id Product ID (e.g., com.example.sub) --ref-name Reference name ``` The Go code passes `Name` and `ProductID` to the API, but **never sets `SubscriptionPeriod`** even though the struct supports it. This is simply an incomplete CLI implementation. ## What you CAN set up with asc today | Feature | asc support | |---------|-------------| | Subscription groups | create, list, get, update, delete | | Subscriptions | create (no period), list, get, update (no period), delete | | Subscription period | **not exposed** (API supports it) | | Prices per territory | add, list, delete | | Price points & equalizations | list, query | | Localizations (name/description) | create, update, delete | | Introductory offers (trials) | create, update, delete | | Review screenshots | upload, update, delete | | Promotional offers | create, update, delete | | Availability | set territories | | Grace period | **read-only** | ## Options to fix this expose `--subscription-period` on `subscriptions create` and `subscriptions update`. It's a small change (add the flag and wire it to the struct). ## Grace period Same thing I think, fixed to 14d would be alright.
kerem closed this issue 2026-02-26 21:33:30 +03:00
kerem commented 2026-02-26 21:33:31 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 2, 2026):

@cursor please implement this. Go through the openapi spec and add it

<!-- gh-comment-id:3834611380 --> @rudrankriyam commented on GitHub (Feb 2, 2026): @cursor please implement this. Go through the openapi spec and add it
kerem commented 2026-02-26 21:33:31 +03:00
Author
Owner
Copy link

@cursor[bot] commented on GitHub (Feb 2, 2026):

Summary:

  • I wired --subscription-period into subscriptions create and subscriptions update with validation so the API request includes the chosen period (ONE_WEEK, ONE_MONTH, TWO_MONTHS, THREE_MONTHS, SIX_MONTHS, ONE_YEAR).
// ...
subscriptionPeriod := fs.String("subscription-period", "", "Subscription period: "+strings.Join(subscriptionPeriodValues, ", "))
// ...
period, err := normalizeSubscriptionPeriod(*subscriptionPeriod, false)
// ...
if period != "" {
	attrs.SubscriptionPeriod = string(period)
}

// ...
subscriptionPeriod := fs.String("subscription-period", "", "Subscription period: "+strings.Join(subscriptionPeriodValues, ", "))
// ...
period, err := normalizeSubscriptionPeriod(*subscriptionPeriod, false)
// ...
if period != "" {
	periodValue := string(period)
	attrs.SubscriptionPeriod = &periodValue
}
  • I added subscriptions grace-periods update with opt-in/sandbox opt-in, duration, and renewal-type flags, and wired it to the update call.
func SubscriptionsGracePeriodsUpdateCommand() *ffcli.Command {
	// ...
	duration := fs.String("duration", "", "Grace period duration: "+strings.Join(subscriptionGracePeriodDurationValues, ", "))
	renewalType := fs.String("renewal-type", "", "Grace period renewal type: "+strings.Join(subscriptionGracePeriodRenewalTypeValues, ", "))
	// ...
	attrs := asc.SubscriptionGracePeriodUpdateAttributes{}
	// ...
	resp, err := client.UpdateSubscriptionGracePeriod(requestCtx, id, attrs)
	// ...
}

Testing:

  • make test

Walkthrough artifact:

  • cli_subscription_period_grace_period_help_visible/recording_demo.mp4 (shows go run . subscriptions create --help and go run . subscriptions grace-periods update --help with the new flags).

View PR
Open in Cursor Open in Web

<!-- gh-comment-id:3834611819 --> @cursor[bot] commented on GitHub (Feb 2, 2026): Summary: - I wired `--subscription-period` into `subscriptions create` and `subscriptions update` with validation so the API request includes the chosen period (ONE_WEEK, ONE_MONTH, TWO_MONTHS, THREE_MONTHS, SIX_MONTHS, ONE_YEAR). ```448:509:internal/cli/subscriptions/subscriptions.go // ... subscriptionPeriod := fs.String("subscription-period", "", "Subscription period: "+strings.Join(subscriptionPeriodValues, ", ")) // ... period, err := normalizeSubscriptionPeriod(*subscriptionPeriod, false) // ... if period != "" { attrs.SubscriptionPeriod = string(period) } ``` ```564:618:internal/cli/subscriptions/subscriptions.go // ... subscriptionPeriod := fs.String("subscription-period", "", "Subscription period: "+strings.Join(subscriptionPeriodValues, ", ")) // ... period, err := normalizeSubscriptionPeriod(*subscriptionPeriod, false) // ... if period != "" { periodValue := string(period) attrs.SubscriptionPeriod = &periodValue } ``` - I added `subscriptions grace-periods update` with opt-in/sandbox opt-in, duration, and renewal-type flags, and wired it to the update call. ```84:162:internal/cli/subscriptions/grace_periods.go func SubscriptionsGracePeriodsUpdateCommand() *ffcli.Command { // ... duration := fs.String("duration", "", "Grace period duration: "+strings.Join(subscriptionGracePeriodDurationValues, ", ")) renewalType := fs.String("renewal-type", "", "Grace period renewal type: "+strings.Join(subscriptionGracePeriodRenewalTypeValues, ", ")) // ... attrs := asc.SubscriptionGracePeriodUpdateAttributes{} // ... resp, err := client.UpdateSubscriptionGracePeriod(requestCtx, id, attrs) // ... } ``` Testing: - `make test` Walkthrough artifact: - `cli_subscription_period_grace_period_help_visible/recording_demo.mp4` (shows `go run . subscriptions create --help` and `go run . subscriptions grace-periods update --help` with the new flags). <a href="https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/399"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/view-pr-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/view-pr-light.png"><img alt="View PR" width="86" height="28" src="https://cursor.com/assets/images/view-pr-light.png"></picture></a> <a href="https://cursor.com/background-agent?bcId=bc-a4a135fd-3571-49ca-bc7f-800e6300add5"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;<a href="https://cursor.com/agents?id=bc-a4a135fd-3571-49ca-bc7f-800e6300add5"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>
kerem commented 2026-02-26 21:33:31 +03:00
Author
Owner
Copy link

@rudrankriyam commented on GitHub (Feb 2, 2026):

Thanks for the report! This is now fixed in v0.23.5 (tagged release).

Changes included:

  • Added --subscription-period to asc subscriptions create and asc subscriptions update.
  • Added asc subscriptions grace-periods update for opt-in, sandbox opt-in, duration, and renewal type.

Note: the App Store Connect API currently rejects updates to subscriptionPeriod on existing subscriptions ("SubscriptionPeriod cannot be updated.") — create supports it, update does not.

Release: https://github.com/rudrankriyam/App-Store-Connect-CLI/releases/tag/0.23.5

<!-- gh-comment-id:3834906448 --> @rudrankriyam commented on GitHub (Feb 2, 2026): Thanks for the report! This is now fixed in v0.23.5 (tagged release). Changes included: - Added `--subscription-period` to `asc subscriptions create` and `asc subscriptions update`. - Added `asc subscriptions grace-periods update` for opt-in, sandbox opt-in, duration, and renewal type. Note: the App Store Connect API currently rejects updates to `subscriptionPeriod` on existing subscriptions ("SubscriptionPeriod cannot be updated.") — create supports it, update does not. Release: https://github.com/rudrankriyam/App-Store-Connect-CLI/releases/tag/0.23.5
kerem commented 2026-02-26 21:33:31 +03:00
Author
Owner
Copy link

@flutterrausch commented on GitHub (Feb 2, 2026):

Wow, you are the speed king, thanks a lot!

❤️

<!-- gh-comment-id:3835090186 --> @flutterrausch commented on GitHub (Feb 2, 2026): Wow, you are the speed king, thanks a lot! ❤️
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
1.2.6
1.2.5
1.2.4
1.2.3
1.2.2
1.2.1
1.2.0
1.1.1
1.1.0
1.0.1
1.0.0
0.49.1
0.49.0
0.48.1
0.48.0
0.47.1
0.47.0
0.46.2
0.46.1
0.46.0
0.45.4
0.45.3
0.45.2
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.0
0.42.0
0.41.4
0.41.3
0.41.2
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.3
0.38.2
0.38.1
0.38.0
0.37.3
0.37.2
0.37.1
0.37.0
0.36.3
0.36.2
0.36.1
0.36.0
0.35.3
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.2
0.33.1
0.33.0
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.3
0.29.2
0.29.1
0.29.0
0.28.14
0.28.13
0.28.12
0.28.11
0.28.10
0.28.9
0.28.8
0.28.7
0.28.6
0.28.5
0.28.4
0.28.3
0.28.2
0.28.1
0.28.0
0.27.0
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.4
0.25.3
0.25.1
0.25.0
0.24.3
0.24.2
0.24.1
0.24.0
0.23.5
0.23.4
0.23.3
0.23.2
0.23.1
0.23.0
0.22.1
0.22.0
0.21.0
0.20.2
0.20.1
0.20.0
0.19.3
0.19.2
0.19.1
0.19.0
0.18.2
0.18.1
0.18.0
0.17.0
0.16.0
0.15.0
0.14.0
0.13.0
0.12.4
0.12.3
0.12.2
0.12.1
0.12.0
0.11.0
0.10.2
0.10.1
0.10.0
0.9.0
0.8.1
0.8.0
0.7.0
0.6.0
0.5.0
0.3.1
0.3.0
0.2.0
0.1.6
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
bug

   
bug

   
documentation

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
bug
documentation
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#112
No description provided.