[PR #267] [MERGED] Harden pagination, errors, and temp key cleanup #398

New issue

Closed

opened 2026-02-26 22:30:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/267
Author: @rudrankriyam
Created: 1/28/2026
Status: ✅ Merged
Merged: 1/28/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/audit-hardening

📝 Commits (3)

bc4ebd8 fix: harden pagination and error handling
23b95a6 Refactor main cleanup flow
b1912ee Merge pull request #274 from rudrankriyam/cursor/main-function-cleanup-pattern-9dce

📊 Changes

6 files changed (+90 additions, -12 deletions)

View changed files

📝 cmd/shared.go (+9 -0)
📝 internal/asc/client_pagination.go (+5 -0)
📝 internal/asc/client_test.go (+30 -0)
📝 internal/asc/errors.go (+11 -8)
➕ internal/asc/errors_test.go (+22 -0)
📝 main.go (+13 -4)

📄 Description

Summary

clean up temp private key files created from env values, even on early exits
detect repeated pagination URLs to prevent infinite pagination loops
sanitize API error output and add coverage for the new guardrails

Test plan

go test ./internal/asc -run "TestPaginateAll_DetectsRepeatedNextURL|TestAPIErrorError_SanitizesControlCharacters"

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/267 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/28/2026 **Status:** ✅ Merged **Merged:** 1/28/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/audit-hardening` --- ### 📝 Commits (3) - [`bc4ebd8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/bc4ebd82b4db77f2e1dad02adcdb9458d6b16fe3) fix: harden pagination and error handling - [`23b95a6`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/23b95a6c7a1e5fea92535824654d9a5eba24d36a) Refactor main cleanup flow - [`b1912ee`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b1912ee0b96b9a59f6b903014e517cf8c0a7ed92) Merge pull request #274 from rudrankriyam/cursor/main-function-cleanup-pattern-9dce ### 📊 Changes **6 files changed** (+90 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `cmd/shared.go` (+9 -0) 📝 `internal/asc/client_pagination.go` (+5 -0) 📝 `internal/asc/client_test.go` (+30 -0) 📝 `internal/asc/errors.go` (+11 -8) ➕ `internal/asc/errors_test.go` (+22 -0) 📝 `main.go` (+13 -4) </details> ### 📄 Description ## Summary - clean up temp private key files created from env values, even on early exits - detect repeated pagination URLs to prevent infinite pagination loops - sanitize API error output and add coverage for the new guardrails ## Test plan - [x] go test ./internal/asc -run "TestPaginateAll_DetectsRepeatedNextURL|TestAPIErrorError_SanitizesControlCharacters" --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>