mirror of
https://github.com/1Remote/1Remote.git
synced 2026-04-25 13:36:03 +03:00
[GH-ISSUE #37] Huge memory leaks #29
Labels
No labels
area-configuration
area-ct-app
area-ct-rdp
area-ct-remoteapp
area-ct-ssh
area-ct-vnc
area-launcher
area-list
area-tags
area-teamwork
bug
chore
dependencies
general-build/ci
general-performance
general-refactor
general-security
general-supportive
general-ux
meta-documentation
meta-enhancement
meta-enhancement
meta-feature
meta-help-wanted
meta-unknown-error
priority-hi
priority-low
pull-request
question
resolution-duplicate
resolution-invalid
resolution-wontfix
stale
task-put-off
task-still-considering
task-working-in-progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/1Remote#29
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @majkinetor on GitHub (Dec 12, 2020).
Original GitHub issue: https://github.com/1Remote/1Remote/issues/37
Originally assigned to: @VShawn on GitHub.
Describe the bug
The application is leaking huge amounts of memory. While it is pretty snappy and fast during work, it slowly hogs the system down. Each time you start RDP session, it goes up. When nothing works (no session is active and PRM is in tray) it keeps all that memory.
The image bellow is after starting and closing 3 RDP connections total 15 times (which I do in my usual work in few hours) and letting it stay for the night (to see if the GC will kick in but it didn't). You can see it eats 2+ GB memory which is double the next most hungry app - Chrome browser.
Expected behavior
At least when no session is running and PRM is in tray, it should go next to the zero. This kind of tools should never use more then few hundred MBs.
@VShawn commented on GitHub (Dec 13, 2020):
bug confirm.
It seems like unrelease of AxMSTSCLib, but I tried Dispose() which gives no help at all.
More document about how the exit AxMSTSCLib correctly is needed.
@VShawn commented on GitHub (Dec 13, 2020):
looks like works
@majkinetor commented on GitHub (Dec 13, 2020):
Gr8. I'll test it again when you release this.
@VShawn commented on GitHub (Dec 13, 2020):
i found the huge memory leaks are fixed, still some little memory growth, I ignored them this time.
@majkinetor commented on GitHub (Dec 16, 2020):
I confirm this. It still eats memory quite a bit, without any connection just by bringing launcher it takes 150MB while it should probably take ~10... but that is all tolerable in current paradigm where electron apps can take much more doing no more then todo management.