[GH-ISSUE #11] rate timer #9

Closed
opened 2026-02-27 04:57:05 +03:00 by kerem · 9 comments
Owner

Originally created by @pxrave on GitHub (Apr 8, 2025).
Original GitHub issue: https://github.com/Googolplexed0/zotify/issues/11

Originally assigned to: @Googolplexed0 on GitHub.

when downloading multible songs rate limiter always hit.

should be 30 or more seconds after every song.

Originally created by @pxrave on GitHub (Apr 8, 2025). Original GitHub issue: https://github.com/Googolplexed0/zotify/issues/11 Originally assigned to: @Googolplexed0 on GitHub. when downloading multible songs rate limiter always hit. should be 30 or more seconds after every song.
kerem 2026-02-27 04:57:05 +03:00
Author
Owner

@Googolplexed0 commented on GitHub (Apr 9, 2025):

You can already set the config BULK_WAIT_TIME to whatever time (in seconds) you want to wait between song downloads. I did add a reference to this suggested BULK_WAIT_TIME in the README in commit 25221af, for those who don't know how to solve it.

<!-- gh-comment-id:2789742022 --> @Googolplexed0 commented on GitHub (Apr 9, 2025): You can already set the config BULK_WAIT_TIME to whatever time (in seconds) you want to wait between song downloads. I did add a reference to this suggested BULK_WAIT_TIME in the README in commit 25221af, for those who don't know how to solve it.
Author
Owner

@ccrowles commented on GitHub (May 20, 2025):

You can already set the config BULK_WAIT_TIME to whatever time (in seconds) you want to wait between song downloads. I did add a reference to this suggested BULK_WAIT_TIME in the README in commit 25221af, for those who don't know how to solve it.

Does it also work with the command for downloading liked songs? Asking because I set it to 30 but it doesn't seem to wait 30 seconds between each song download.

<!-- gh-comment-id:2895239370 --> @ccrowles commented on GitHub (May 20, 2025): > You can already set the config BULK_WAIT_TIME to whatever time (in seconds) you want to wait between song downloads. I did add a reference to this suggested BULK_WAIT_TIME in the README in commit [25221af](https://github.com/Googolplexed0/zotify/commit/25221aff741f779ebae360d50ea11175a0985687), for those who don't know how to solve it. Does it also work with the command for downloading liked songs? Asking because I set it to 30 but it doesn't seem to wait 30 seconds between each song download.
Author
Owner

@Googolplexed0 commented on GitHub (May 20, 2025):

Yes, the time.sleep(Zotify.CONFIG.get_bulk_wait_time()) runs directly after any track is downloaded, regardless of what mode is used to select tracks. If a track is not downloaded (is skipped) then the sleep will not run.

Technically, it may still be possible to timeout by doing metadata API requests for each song and then skipping the download, but this seems unlikely to happen.

<!-- gh-comment-id:2895677152 --> @Googolplexed0 commented on GitHub (May 20, 2025): Yes, the `time.sleep(Zotify.CONFIG.get_bulk_wait_time())` runs directly after any track is downloaded, regardless of what mode is used to select tracks. If a track is not downloaded (is skipped) then the sleep will not run. Technically, it may still be possible to timeout by doing metadata API requests for each song and then skipping the download, but this seems unlikely to happen.
Author
Owner

@ccrowles commented on GitHub (May 20, 2025):

Then for whatever reason it's not working for me, it downloaded 10 tracks in a row without any kind of waiting/pause despite the config having the bulk wait time set to 30. I even tried setting it to 60 but nothing changed.

<!-- gh-comment-id:2895701612 --> @ccrowles commented on GitHub (May 20, 2025): Then for whatever reason it's not working for me, it downloaded 10 tracks in a row without any kind of waiting/pause despite the config having the bulk wait time set to 30. I even tried setting it to 60 but nothing changed.
Author
Owner

@Googolplexed0 commented on GitHub (May 20, 2025):

I even tried setting it to 60 but nothing changed.

Okay, that is strange. I just confirmed that it works on my system. Does DOWNLOAD_REAL_TIME take effect for you?

<!-- gh-comment-id:2895736687 --> @Googolplexed0 commented on GitHub (May 20, 2025): > I even tried setting it to 60 but nothing changed. Okay, that is strange. I just confirmed that it works on my system. Does `DOWNLOAD_REAL_TIME` take effect for you?
Author
Owner

@ccrowles commented on GitHub (May 20, 2025):

Yep, download_real_time works as intended. Unless you mean if it respects the bulk wait time, in which case I haven't tried with download_real_time because it's already extremely slow as it is.

<!-- gh-comment-id:2895853643 --> @ccrowles commented on GitHub (May 20, 2025): Yep, download_real_time works as intended. Unless you mean if it respects the bulk wait time, in which case I haven't tried with download_real_time because it's already extremely slow as it is.
Author
Owner

@Googolplexed0 commented on GitHub (May 20, 2025):

Yep, download_real_time works as intended. Unless you mean if it respects the bulk wait time, in which case I haven't tried with download_real_time because it's already extremely slow as it is.

Sounds like it is correctly reading your config.json then. Try after commit 3d80e90 and see if that fixes anything. You should see ### WAITING FOR 30 SECONDS BETWEEN DOWNLOADS ###, if nothing prints or the time is None then I will have to dig further.

<!-- gh-comment-id:2895980616 --> @Googolplexed0 commented on GitHub (May 20, 2025): > Yep, download_real_time works as intended. Unless you mean if it respects the bulk wait time, in which case I haven't tried with download_real_time because it's already extremely slow as it is. Sounds like it is correctly reading your `config.json` then. Try after commit 3d80e90 and see if that fixes anything. You should see `### WAITING FOR 30 SECONDS BETWEEN DOWNLOADS ###`, if nothing prints or the time is `None` then I will have to dig further.
Author
Owner

@ccrowles commented on GitHub (May 21, 2025):

Try after commit 3d80e90 and see if that fixes anything. You should see ### WAITING FOR 30 SECONDS BETWEEN DOWNLOADS ###, if nothing prints or the time is None then I will have to dig further.

Should I simply update by running the install command again, or should I uninstall zotify and then install?

<!-- gh-comment-id:2896937756 --> @ccrowles commented on GitHub (May 21, 2025): > Try after commit [3d80e90](https://github.com/Googolplexed0/zotify/commit/3d80e908d2cbd542944352a1e833f8879f53dab3) and see if that fixes anything. You should see `### WAITING FOR 30 SECONDS BETWEEN DOWNLOADS ###`, if nothing prints or the time is `None` then I will have to dig further. Should I simply update by running the install command again, or should I uninstall zotify and then install?
Author
Owner

@Googolplexed0 commented on GitHub (Jun 5, 2025):

Either should work, but the install command may require the --upgrade flag.

<!-- gh-comment-id:2946681099 --> @Googolplexed0 commented on GitHub (Jun 5, 2025): Either should work, but the install command may require the `--upgrade` flag.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/zotify#9
No description provided.