[PR #85] [MERGED] (fix): key error when paging and allow moving of files across different filesystems and docker mounts #166

New issue

Closed

opened 2026-02-27 04:57:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 04:57:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Googolplexed0/zotify/pull/85
Author: @Phlogi
Created: 9/22/2025
Status: ✅ Merged
Merged: 10/12/2025
Merged by: @Googolplexed0

Base: main ← Head: fixes-main1

📝 Commits (5)

9e3885f fix(config): handle missing keys in paginated API responses
b63f899 fix(track): replace Path.rename with shutil.move for temp files
34f2e74 minor touchups
c053855 version bump v0.9.29
936bbb8 Merge branch 'main' into fixes-main1

📊 Changes

3 files changed (+14 additions, -7 deletions)

View changed files

📝 zotify/__init__.py (+1 -1)
📝 zotify/config.py (+10 -4)
📝 zotify/track.py (+3 -2)

📄 Description

Add checks for missing response_key in both initial and paginated API responses to prevent KeyError and log warnings when keys are absent. This improves robustness and fixes the -a artist download which is broken for me on main.
Use shutil.move instead of Path.rename to reliably handle temp file moves, including cross-device scenarios. Prevent possible errors when moving files across devices by replacing Path.replace with shutil.move in convert_audio_format. This ensures audio conversion works reliably even if the temporary directory is on a different file system.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Googolplexed0/zotify/pull/85 **Author:** [@Phlogi](https://github.com/Phlogi) **Created:** 9/22/2025 **Status:** ✅ Merged **Merged:** 10/12/2025 **Merged by:** [@Googolplexed0](https://github.com/Googolplexed0) **Base:** `main` ← **Head:** `fixes-main1` --- ### 📝 Commits (5) - [`9e3885f`](https://github.com/Googolplexed0/zotify/commit/9e3885fd278ef9f7c9bd6f56f13dbefd65fcd15d) fix(config): handle missing keys in paginated API responses - [`b63f899`](https://github.com/Googolplexed0/zotify/commit/b63f8997ac5b4fbead9c5e43a7fe63ce34d39167) fix(track): replace Path.rename with shutil.move for temp files - [`34f2e74`](https://github.com/Googolplexed0/zotify/commit/34f2e748b1bf47c9ffd53d4c0b435916fef8df43) minor touchups - [`c053855`](https://github.com/Googolplexed0/zotify/commit/c05385568e7ea6e564f9f5b5268bd7e63d3cd835) version bump v0.9.29 - [`936bbb8`](https://github.com/Googolplexed0/zotify/commit/936bbb87b5925371af4b41bd352b280f0359aaa9) Merge branch 'main' into fixes-main1 ### 📊 Changes **3 files changed** (+14 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `zotify/__init__.py` (+1 -1) 📝 `zotify/config.py` (+10 -4) 📝 `zotify/track.py` (+3 -2) </details> ### 📄 Description - Add checks for missing `response_key` in both initial and paginated API responses to prevent KeyError and log warnings when keys are absent. This improves robustness and fixes the -a artist download which is broken for me on main. - Use shutil.move instead of Path.rename to reliably handle temp file moves, including cross-device scenarios. Prevent possible errors when moving files across devices by replacing Path.replace with shutil.move in convert_audio_format. This ensures audio conversion works reliably even if the temporary directory is on a different file system. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>