[GH-ISSUE #142] [Bug Report] Non-Optimized Downloading Causes Error #124

Closed
opened 2026-02-27 04:57:41 +03:00 by kerem · 8 comments
Owner

Originally created by @agenbite on GitHub (Jan 6, 2026).
Original GitHub issue: https://github.com/Googolplexed0/zotify/issues/142

Originally assigned to: @Googolplexed0 on GitHub.

While trying to download a big album collection, I was using OPTIMIZED_DOWNLOADING=False in order to download full albums one by one, and everything worked fine for a while. However, this has stopped working and now zotify ends without an error as soon as it starts downloading any song. With optimized downloading it does work, but will leave me with a lot of incomplete albums for a long time. I wonder if "the parent company" has flagged me or if there's something wrong at my side?

Originally created by @agenbite on GitHub (Jan 6, 2026). Original GitHub issue: https://github.com/Googolplexed0/zotify/issues/142 Originally assigned to: @Googolplexed0 on GitHub. While trying to download a big album collection, I was using `OPTIMIZED_DOWNLOADING=False` in order to download full albums one by one, and everything worked fine for a while. However, this has stopped working and now zotify ends without an error as soon as it starts downloading any song. With optimized downloading it does work, but will leave me with a lot of incomplete albums for a long time. I wonder if "the parent company" has flagged me or if there's something wrong at my side?
kerem 2026-02-27 04:57:41 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@RGPZ commented on GitHub (Jan 6, 2026):

My config.json file in the Zotify roaming folder didn't have "OPTIMIZED_DOWNLOADING": "False" in the list so the config.DEBUG.json would just keep seeing optimized_downloading to true. I've gone and added the variable to the config.json file (with the setting as false) and then set the variable in config.debug.json to false and now I'm waiting to see if it either downloads or throws me an error, the download just seems to be hanging at the moment.

For some reason when I tried to download a specific artist it would download a whole bunch of other artist songs and I assume that this is connected to that issue that I'm also having.

<!-- gh-comment-id:3716149768 --> @RGPZ commented on GitHub (Jan 6, 2026): My config.json file in the Zotify roaming folder didn't have "OPTIMIZED_DOWNLOADING": "False" in the list so the config.DEBUG.json would just keep seeing optimized_downloading to true. I've gone and added the variable to the config.json file (with the setting as false) and then set the variable in config.debug.json to false and now I'm waiting to see if it either downloads or throws me an error, the download just seems to be hanging at the moment. For some reason when I tried to download a specific artist it would download a whole bunch of other artist songs and I assume that this is connected to that issue that I'm also having.
Author
Owner

@RGPZ commented on GitHub (Jan 10, 2026):

UPDATE: (I forgot to respond to this) It does work, it just seems to take a while until it starts. Sadly it's not fixed my issue on downloading artists because for some reason it still just ends up downloading songs from other artists which I do not understand as to why.

<!-- gh-comment-id:3733650016 --> @RGPZ commented on GitHub (Jan 10, 2026): UPDATE: (I forgot to respond to this) It does work, it just seems to take a while until it starts. Sadly it's not fixed my issue on downloading artists because for some reason it still just ends up downloading songs from other artists which I do not understand as to why.
Author
Owner

@agenbite commented on GitHub (Jan 11, 2026):

It still doesn't work for me, but I ended up doing what I needed by downloading a list of URIs from the albums in my library (through the standard "download my info" link in the website config) and iterating through it with a script which calls zotify on each URI.

<!-- gh-comment-id:3734917944 --> @agenbite commented on GitHub (Jan 11, 2026): It still doesn't work for me, but I ended up doing what I needed by downloading a list of URIs from the albums in my library (through the standard "download my info" link in the website config) and iterating through it with a script which calls zotify on each URI.
Author
Owner

@Googolplexed0 commented on GitHub (Jan 20, 2026):

@agenbite see if the new-hierarchy branch fixes this issue.

<!-- gh-comment-id:3770803176 --> @Googolplexed0 commented on GitHub (Jan 20, 2026): @agenbite see if the [new-hierarchy branch](https://github.com/Googolplexed0/zotify/tree/new-hierarchy) fixes this issue.
Author
Owner

@agenbite commented on GitHub (Jan 20, 2026):

I can't seem to run this branch. If I try to download an album after zotify -s whatever, I get the following error:

Traceback (most recent call last):
  File "/home/me/.local/bin/zotify", line 7, in <module>
    sys.exit(main())
             ~~~~^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/__main__.py", line 143, in main
    client(args, modes)
    ~~~~~~^^^^^^^^^^^^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/app.py", line 186, in client
    perform_query(args)
    ~~~~~~~~~~~~~^^^^^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/app.py", line 178, in perform_query
    raise e
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/app.py", line 171, in perform_query
    search_and_select(args.search)
    ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/app.py", line 129, in search_and_select
    Query(Zotify.DATETIME_LAUNCH).request(' '.join(uris)).execute()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 1509, in execute
    self.download()
    ~~~~~~~~~~~~~^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 1454, in download
    nonskipped = [ps for ps in pss if not ps.check_skippable()] # handles already downloaded
                                          ~~~~~~~~~~~~~~~~~~^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 1292, in check_skippable
    return any(c.check_skippable(self) for c in self[::-1])
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 1292, in <genexpr>
    return any(c.check_skippable(self) for c in self[::-1])
               ~~~~~~~~~~~~~~~~~^^^^^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 580, in check_skippable
    self.skippable = super().check_skippable(parent_stack)
                     ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 329, in check_skippable
    path = self.fill_output_template(parent_stack)
  File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 574, in fill_output_template
    for replstr, md_val in repl_dict.values():
        ^^^^^^^^^^^^^^^
ValueError: too many values to unpack (expected 2)
<!-- gh-comment-id:3771810240 --> @agenbite commented on GitHub (Jan 20, 2026): I can't seem to run this branch. If I try to download an album after `zotify -s whatever`, I get the following error: ``` Traceback (most recent call last): File "/home/me/.local/bin/zotify", line 7, in <module> sys.exit(main()) ~~~~^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/__main__.py", line 143, in main client(args, modes) ~~~~~~^^^^^^^^^^^^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/app.py", line 186, in client perform_query(args) ~~~~~~~~~~~~~^^^^^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/app.py", line 178, in perform_query raise e File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/app.py", line 171, in perform_query search_and_select(args.search) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/app.py", line 129, in search_and_select Query(Zotify.DATETIME_LAUNCH).request(' '.join(uris)).execute() ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 1509, in execute self.download() ~~~~~~~~~~~~~^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 1454, in download nonskipped = [ps for ps in pss if not ps.check_skippable()] # handles already downloaded ~~~~~~~~~~~~~~~~~~^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 1292, in check_skippable return any(c.check_skippable(self) for c in self[::-1]) File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 1292, in <genexpr> return any(c.check_skippable(self) for c in self[::-1]) ~~~~~~~~~~~~~~~~~^^^^^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 580, in check_skippable self.skippable = super().check_skippable(parent_stack) ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^ File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 329, in check_skippable path = self.fill_output_template(parent_stack) File "/home/me/.local/share/pipx/venvs/zotify/lib/python3.13/site-packages/zotify/api.py", line 574, in fill_output_template for replstr, md_val in repl_dict.values(): ^^^^^^^^^^^^^^^ ValueError: too many values to unpack (expected 2) ```
Author
Owner

@agenbite commented on GitHub (Jan 20, 2026):

This has been already reported: https://github.com/Googolplexed0/zotify/issues/155

<!-- gh-comment-id:3772474389 --> @agenbite commented on GitHub (Jan 20, 2026): This has been already reported: https://github.com/Googolplexed0/zotify/issues/155
Author
Owner

@Googolplexed0 commented on GitHub (Jan 21, 2026):

Sadly it's not fixed my issue on downloading artists because for some reason it still just ends up downloading songs from other artists which I do not understand as to why.

See #130 for the new artist-related config options.

This has been already reported: #155

Just fixed. Are you still seeing your original OPTIMIZED_DOWNLOADING=False error?

<!-- gh-comment-id:3776322154 --> @Googolplexed0 commented on GitHub (Jan 21, 2026): > Sadly it's not fixed my issue on downloading artists because for some reason it still just ends up downloading songs from other artists which I do not understand as to why. See #130 for the new artist-related config options. > This has been already reported: [#155](https://github.com/Googolplexed0/zotify/issues/155) Just fixed. Are you still seeing your original `OPTIMIZED_DOWNLOADING=False` error?
Author
Owner

@agenbite commented on GitHub (Jan 21, 2026):

Are you still seeing your original OPTIMIZED_DOWNLOADING=False error?

Nope!! :) Thanks!!

<!-- gh-comment-id:3776783151 --> @agenbite commented on GitHub (Jan 21, 2026): > Are you still seeing your original OPTIMIZED_DOWNLOADING=False error? Nope!! :) Thanks!!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/zotify#124
No description provided.