[PR #55] [MERGED] Better handling of stale PID files #179

New issue

Closed

opened 2026-02-27 08:14:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 08:14:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/lucascbeyeler/zmbackup/pull/55
Author: @crebelein
Created: 11/29/2017
Status: ✅ Merged
Merged: 12/6/2017
Merged by: @lucascbeyeler

Base: 1.2-version ← Head: 1.2-version

📝 Commits (2)

ce8df26 Do not leave a stale PID file behind
7231c55 Check for stale PID file

📊 Changes

2 files changed (+12 additions, -4 deletions)

View changed files

📝 project/lib/bash/DeleteAction.sh (+1 -0)
📝 project/lib/bash/MiscAction.sh (+11 -4)

📄 Description

delete_one in DeleteAction.sh is leaving behind a stale PID file due to the exit 2 (which appears to be present to suppress meaningless errors). This PID file should be deleted prior to the exit.

Additionally, stale PID files can occur from time to time for various reasons. Have checkpid in MiscActions.sh investigate if the PID is stale or not and act accordingly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/lucascbeyeler/zmbackup/pull/55 **Author:** [@crebelein](https://github.com/crebelein) **Created:** 11/29/2017 **Status:** ✅ Merged **Merged:** 12/6/2017 **Merged by:** [@lucascbeyeler](https://github.com/lucascbeyeler) **Base:** `1.2-version` ← **Head:** `1.2-version` --- ### 📝 Commits (2) - [`ce8df26`](https://github.com/lucascbeyeler/zmbackup/commit/ce8df2607b81a21fa7866dda2e0f167b5e3c1e35) Do not leave a stale PID file behind - [`7231c55`](https://github.com/lucascbeyeler/zmbackup/commit/7231c550a4eb2375960ace35d36300c0f86a18a2) Check for stale PID file ### 📊 Changes **2 files changed** (+12 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `project/lib/bash/DeleteAction.sh` (+1 -0) 📝 `project/lib/bash/MiscAction.sh` (+11 -4) </details> ### 📄 Description `delete_one` in `DeleteAction.sh` is leaving behind a stale PID file due to the `exit 2` (which appears to be present to suppress meaningless errors). This PID file should be deleted prior to the exit. Additionally, stale PID files can occur from time to time for various reasons. Have `checkpid` in `MiscActions.sh` investigate if the PID is stale or not and act accordingly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>