[GH-ISSUE #94] More than 20 results from a search? #72

Closed
opened 2026-02-27 22:07:52 +03:00 by kerem · 2 comments
Owner

Originally created by @natumbri on GitHub (Oct 28, 2020).
Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/94

Originally assigned to: @natumbri on GitHub.

Any interest in returning more than 20 results from a search?

I've had a go, and it seems to work: https://github.com/natumbri/ytmusicapi/tree/fix/more-results

Let me know if you'd like a pull request. I haven't tested it with authorisation.

Originally created by @natumbri on GitHub (Oct 28, 2020). Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/94 Originally assigned to: @natumbri on GitHub. Any interest in returning more than 20 results from a search? I've had a go, and it seems to work: https://github.com/natumbri/ytmusicapi/tree/fix/more-results Let me know if you'd like a pull request. I haven't tested it with authorisation.
kerem 2026-02-27 22:07:52 +03:00
Author
Owner

@sigma67 commented on GitHub (Oct 28, 2020):

Yes, this is one thing I didn't get around to implementing. Great that you've gone ahead with it.

I looked at your code and it looks good, I have just a few suggestions for improvement. Please submit a PR and I will comment there

<!-- gh-comment-id:718089878 --> @sigma67 commented on GitHub (Oct 28, 2020): Yes, this is one thing I didn't get around to implementing. Great that you've gone ahead with it. I looked at your code and it looks good, I have just a few suggestions for improvement. Please submit a PR and I will comment there
Author
Owner

@natumbri commented on GitHub (Oct 28, 2020):

Great - I'll try to make a PR.

I'm pretty hopeless at them, particularly keeping the automatic linting tools under control, and I haven't been able to make the unittests work at all. But I'll have a crack and we'll see how it goes...

<!-- gh-comment-id:718175000 --> @natumbri commented on GitHub (Oct 28, 2020): Great - I'll try to make a PR. I'm pretty hopeless at them, particularly keeping the automatic linting tools under control, and I haven't been able to make the unittests work at all. But I'll have a crack and we'll see how it goes...
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ytmusicapi#72
No description provided.