mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 15:26:01 +03:00
[GH-ISSUE #94] More than 20 results from a search? #72
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#72
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @natumbri on GitHub (Oct 28, 2020).
Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/94
Originally assigned to: @natumbri on GitHub.
Any interest in returning more than 20 results from a search?
I've had a go, and it seems to work: https://github.com/natumbri/ytmusicapi/tree/fix/more-results
Let me know if you'd like a pull request. I haven't tested it with authorisation.
@sigma67 commented on GitHub (Oct 28, 2020):
Yes, this is one thing I didn't get around to implementing. Great that you've gone ahead with it.
I looked at your code and it looks good, I have just a few suggestions for improvement. Please submit a PR and I will comment there
@natumbri commented on GitHub (Oct 28, 2020):
Great - I'll try to make a PR.
I'm pretty hopeless at them, particularly keeping the automatic linting tools under control, and I haven't been able to make the unittests work at all. But I'll have a crack and we'll see how it goes...