[PR #727] [MERGED] refactor YTMusicBase, improve oauth doc #718

Closed
opened 2026-02-27 23:02:08 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/727
Author: @sigma67
Created: 1/19/2025
Status: Merged
Merged: 1/19/2025
Merged by: @sigma67

Base: mainHead: ytmusic-auth-refactor


📝 Commits (3)

  • 1b12188 refactor YTMusicBase, improve oauth doc
  • 7820389 fix recursion issue
  • 96f52de fix bugs, fix coverage, add session test

📊 Changes

6 files changed (+135 additions, -99 deletions)

View changed files

📝 docs/source/usage.rst (+2 -1)
📝 tests/auth/test_oauth.py (+11 -0)
📝 tests/test_ytmusic.py (+14 -0)
ytmusicapi/auth/auth_parse.py (+51 -0)
📝 ytmusicapi/auth/types.py (+0 -7)
📝 ytmusicapi/ytmusic.py (+57 -91)

📄 Description

  • improved OAuth documentation, raise when oauth_credentials are missing
  • removed option to disable session usage
  • removed non-functional OAUTH_DEFAULT AuthType
  • improved readability of ytmusic.py/YTMusicBase

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/727 **Author:** [@sigma67](https://github.com/sigma67) **Created:** 1/19/2025 **Status:** ✅ Merged **Merged:** 1/19/2025 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `ytmusic-auth-refactor` --- ### 📝 Commits (3) - [`1b12188`](https://github.com/sigma67/ytmusicapi/commit/1b1218835842bb8888b1f11a7fe42df18d77f034) refactor YTMusicBase, improve oauth doc - [`7820389`](https://github.com/sigma67/ytmusicapi/commit/7820389865fe860f54670fdc96f97a82bb24477c) fix recursion issue - [`96f52de`](https://github.com/sigma67/ytmusicapi/commit/96f52de0757197cfbbbaa5c85775dd7e911e2862) fix bugs, fix coverage, add session test ### 📊 Changes **6 files changed** (+135 additions, -99 deletions) <details> <summary>View changed files</summary> 📝 `docs/source/usage.rst` (+2 -1) 📝 `tests/auth/test_oauth.py` (+11 -0) 📝 `tests/test_ytmusic.py` (+14 -0) ➕ `ytmusicapi/auth/auth_parse.py` (+51 -0) 📝 `ytmusicapi/auth/types.py` (+0 -7) 📝 `ytmusicapi/ytmusic.py` (+57 -91) </details> ### 📄 Description - improved OAuth documentation, raise when oauth_credentials are missing - removed option to disable session usage - removed non-functional OAUTH_DEFAULT AuthType - improved readability of ytmusic.py/YTMusicBase --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:02:08 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ytmusicapi#718
No description provided.