[PR #693] [MERGED] Added Lyrics w. Timestamps #662 #705

New issue

Closed

opened 2026-02-27 23:02:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:02:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/693
Author: @sigma67
Created: 12/17/2024
Status: ✅ Merged
Merged: 12/17/2024
Merged by: @sigma67

Base: main ← Head: heinrich26-patch-1

📝 Commits (10+)

9cfc67c Added Lyrics w. Timestamps
a70de71 Update browsing.py
c4d90de Combined both get_lyrics methods into one and fixed some typechecking errors
c85369f Fixed a missing hasTimestamps and added the doccomments to the overloads, because vscode didn't show them otherwise
a657a37 Removed the old get_lyrics_with_timestamps method
2ffc136 fixed remaining issues
83b6e92 Update uploads.py
47a8504 removed variable context from the Mixin, as it's use was replaced by yt.as_mobile()
fc1dec4 fix some formatting complaints by ruff and mypy
347c2e6 please the linter

📊 Changes

12 files changed (+246 additions, -82 deletions)

View changed files

➖ .github/workflows/docsbuild.yml (+0 -33)
📝 tests/mixins/test_browsing.py (+18 -2)
📝 ytmusicapi/__init__.py (+1 -1)
📝 ytmusicapi/mixins/_protocol.py (+8 -1)
📝 ytmusicapi/mixins/_utils.py (+4 -1)
📝 ytmusicapi/mixins/browsing.py (+88 -21)
📝 ytmusicapi/mixins/library.py (+8 -6)
📝 ytmusicapi/mixins/uploads.py (+8 -4)
➕ ytmusicapi/models/__init__.py (+3 -0)
➕ ytmusicapi/models/lyrics.py (+46 -0)
📝 ytmusicapi/navigation.py (+10 -0)
📝 ytmusicapi/ytmusic.py (+52 -13)

📄 Description

copy of #662

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/693 **Author:** [@sigma67](https://github.com/sigma67) **Created:** 12/17/2024 **Status:** ✅ Merged **Merged:** 12/17/2024 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `heinrich26-patch-1` --- ### 📝 Commits (10+) - [`9cfc67c`](https://github.com/sigma67/ytmusicapi/commit/9cfc67c59f29ca8207ba153b4336b5c522755ab0) Added Lyrics w. Timestamps - [`a70de71`](https://github.com/sigma67/ytmusicapi/commit/a70de715ac554781ecdc99165d17a7e6b7582eff) Update browsing.py - [`c4d90de`](https://github.com/sigma67/ytmusicapi/commit/c4d90de2f27d29089d0e3bea5d194e78c0dcd173) Combined both get_lyrics methods into one and fixed some typechecking errors - [`c85369f`](https://github.com/sigma67/ytmusicapi/commit/c85369fa178e094ef91197bdb027c8b70419e6c2) Fixed a missing hasTimestamps and added the doccomments to the overloads, because vscode didn't show them otherwise - [`a657a37`](https://github.com/sigma67/ytmusicapi/commit/a657a370c6b5b047dd63d105881a0cacc8303b53) Removed the old get_lyrics_with_timestamps method - [`2ffc136`](https://github.com/sigma67/ytmusicapi/commit/2ffc1369229704a9a41fa4619d6394e38601a04e) fixed remaining issues - [`83b6e92`](https://github.com/sigma67/ytmusicapi/commit/83b6e92edb978a62ead6171e4539ffcf60d78017) Update uploads.py - [`47a8504`](https://github.com/sigma67/ytmusicapi/commit/47a85049daa80da185d1568b2db25a58b1c16e98) removed variable `context` from the Mixin, as it's use was replaced by `yt.as_mobile()` - [`fc1dec4`](https://github.com/sigma67/ytmusicapi/commit/fc1dec4f81284e13e9978e12a844e878da132251) fix some formatting complaints by ruff and mypy - [`347c2e6`](https://github.com/sigma67/ytmusicapi/commit/347c2e64bd99d0db708ad164a8ee22a84bbd96b9) please the linter ### 📊 Changes **12 files changed** (+246 additions, -82 deletions) <details> <summary>View changed files</summary> ➖ `.github/workflows/docsbuild.yml` (+0 -33) 📝 `tests/mixins/test_browsing.py` (+18 -2) 📝 `ytmusicapi/__init__.py` (+1 -1) 📝 `ytmusicapi/mixins/_protocol.py` (+8 -1) 📝 `ytmusicapi/mixins/_utils.py` (+4 -1) 📝 `ytmusicapi/mixins/browsing.py` (+88 -21) 📝 `ytmusicapi/mixins/library.py` (+8 -6) 📝 `ytmusicapi/mixins/uploads.py` (+8 -4) ➕ `ytmusicapi/models/__init__.py` (+3 -0) ➕ `ytmusicapi/models/lyrics.py` (+46 -0) 📝 `ytmusicapi/navigation.py` (+10 -0) 📝 `ytmusicapi/ytmusic.py` (+52 -13) </details> ### 📄 Description copy of #662 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>