[PR #662] [CLOSED] Added Lyrics w. Timestamps #695

New issue

Closed

opened 2026-02-27 23:02:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:02:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/662
Author: @heinrich26
Created: 10/10/2024
Status: ❌ Closed

Base: main ← Head: patch-1

📝 Commits (10+)

4d4a76f Added Lyrics w. Timestamps
14313be Update browsing.py
0885616 Combined both get_lyrics methods into one and fixed some typechecking errors
28a8828 Fixed a missing hasTimestamps and added the doccomments to the overloads, because vscode didn't show them otherwise
ab032f5 Merge pull request #1 from heinrich26/main
049b0b0 Removed the old get_lyrics_with_timestamps method
3198b1f fixed remaining issues
cfd9a4a Update uploads.py
0c2444c removed variable context from the Mixin, as it's use was replaced by yt.as_mobile()
a8a1f5f fix some formatting complaints by ruff and mypy

📊 Changes

11 files changed (+236 additions, -48 deletions)

View changed files

📝 tests/mixins/test_browsing.py (+18 -2)
📝 ytmusicapi/__init__.py (+1 -1)
📝 ytmusicapi/mixins/_protocol.py (+7 -1)
📝 ytmusicapi/mixins/_utils.py (+4 -1)
📝 ytmusicapi/mixins/browsing.py (+83 -21)
📝 ytmusicapi/mixins/library.py (+8 -6)
📝 ytmusicapi/mixins/uploads.py (+8 -4)
➕ ytmusicapi/models/__init__.py (+3 -0)
➕ ytmusicapi/models/lyrics.py (+46 -0)
📝 ytmusicapi/navigation.py (+10 -0)
📝 ytmusicapi/ytmusic.py (+48 -12)

📄 Description

Added get_lyrics_with_timestamps to get lyrics with timestamps. The Method doesn't try to parse the response as normal lyrics, if no lyrics with timestamps are returned. (could be changed to do so tho, the format is the same)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/662 **Author:** [@heinrich26](https://github.com/heinrich26) **Created:** 10/10/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (10+) - [`4d4a76f`](https://github.com/sigma67/ytmusicapi/commit/4d4a76f41169b5701a84634fafa26d6e32772cf1) Added Lyrics w. Timestamps - [`14313be`](https://github.com/sigma67/ytmusicapi/commit/14313be683003d89652201fde7b943915bb54c89) Update browsing.py - [`0885616`](https://github.com/sigma67/ytmusicapi/commit/088561622ccba8e6e7436e35f21955f431dc4793) Combined both get_lyrics methods into one and fixed some typechecking errors - [`28a8828`](https://github.com/sigma67/ytmusicapi/commit/28a8828181cb51f0a5728671dbc44cab537e858b) Fixed a missing hasTimestamps and added the doccomments to the overloads, because vscode didn't show them otherwise - [`ab032f5`](https://github.com/sigma67/ytmusicapi/commit/ab032f56cbf9646b4583c1d7b231fc1fac51612e) Merge pull request #1 from heinrich26/main - [`049b0b0`](https://github.com/sigma67/ytmusicapi/commit/049b0b07a40d9c270a9641c408beb56abce5ed45) Removed the old get_lyrics_with_timestamps method - [`3198b1f`](https://github.com/sigma67/ytmusicapi/commit/3198b1fb9c6e04f518025d81054113bb1d23f855) fixed remaining issues - [`cfd9a4a`](https://github.com/sigma67/ytmusicapi/commit/cfd9a4ad36a91eaed12b2d88cd0ef06a92e8c59d) Update uploads.py - [`0c2444c`](https://github.com/sigma67/ytmusicapi/commit/0c2444ccf02dcce5c95f80c811222bcf62248023) removed variable `context` from the Mixin, as it's use was replaced by `yt.as_mobile()` - [`a8a1f5f`](https://github.com/sigma67/ytmusicapi/commit/a8a1f5f48fb3ca195db501979bbac9e6d84ce271) fix some formatting complaints by ruff and mypy ### 📊 Changes **11 files changed** (+236 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `tests/mixins/test_browsing.py` (+18 -2) 📝 `ytmusicapi/__init__.py` (+1 -1) 📝 `ytmusicapi/mixins/_protocol.py` (+7 -1) 📝 `ytmusicapi/mixins/_utils.py` (+4 -1) 📝 `ytmusicapi/mixins/browsing.py` (+83 -21) 📝 `ytmusicapi/mixins/library.py` (+8 -6) 📝 `ytmusicapi/mixins/uploads.py` (+8 -4) ➕ `ytmusicapi/models/__init__.py` (+3 -0) ➕ `ytmusicapi/models/lyrics.py` (+46 -0) 📝 `ytmusicapi/navigation.py` (+10 -0) 📝 `ytmusicapi/ytmusic.py` (+48 -12) </details> ### 📄 Description Added `get_lyrics_with_timestamps` to get lyrics with timestamps. The Method doesn't try to parse the response as normal lyrics, if no lyrics with timestamps are returned. (could be changed to do so tho, the format is the same) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>