[PR #657] [MERGED] fix #656: attempt to find runs in subtitle if not in title #692

Closed
opened 2026-02-27 23:02:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/657
Author: @gotofritz
Created: 10/5/2024
Status: Merged
Merged: 10/8/2024
Merged by: @sigma67

Base: mainHead: 656-fix-run-inside-subtitle


📝 Commits (3)

📊 Changes

4 files changed (+41 additions, -56 deletions)

View changed files

📝 tests/conftest.py (+0 -6)
📝 tests/mixins/test_playlists.py (+19 -18)
📝 ytmusicapi/mixins/playlists.py (+2 -20)
📝 ytmusicapi/parsers/playlists.py (+20 -12)

📄 Description

Sometimes the object 'runs' is not to be found within title, but within
subtitle. This PR makes ytmusicapi look in both places.

Closes #656


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/657 **Author:** [@gotofritz](https://github.com/gotofritz) **Created:** 10/5/2024 **Status:** ✅ Merged **Merged:** 10/8/2024 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `656-fix-run-inside-subtitle` --- ### 📝 Commits (3) - [`65c18c4`](https://github.com/sigma67/ytmusicapi/commit/65c18c454c7c55ed10e2f4171db547df238ca544) fix #656: attempt to find runs in subtitle if not in title - [`7ace167`](https://github.com/sigma67/ytmusicapi/commit/7ace16726c8d47ab66c71583ecc0924b6524e674) refactor - [`0138c18`](https://github.com/sigma67/ytmusicapi/commit/0138c183876a2069967c6963740424549c9ecf27) remove fix by gotofritz ### 📊 Changes **4 files changed** (+41 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `tests/conftest.py` (+0 -6) 📝 `tests/mixins/test_playlists.py` (+19 -18) 📝 `ytmusicapi/mixins/playlists.py` (+2 -20) 📝 `ytmusicapi/parsers/playlists.py` (+20 -12) </details> ### 📄 Description Sometimes the object 'runs' is not to be found within title, but within subtitle. This PR makes ytmusicapi look in both places. Closes #656 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:02:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ytmusicapi#692
No description provided.