mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 23:36:00 +03:00
[GH-ISSUE #88] 'remove_playlist_items()' does not work nor does it produce an error when 'videoId' and 'setVideoId' == None #69
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#69
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dvdslv on GitHub (Oct 19, 2020).
Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/88
github.com/sigma67/ytmusicapi@bdbaada36a/ytmusicapi/mixins/playlists.py (L244)My local solution is to add a
continueto my iteration when removing tracks from a playlist where 'videoId' and 'setVideoId' == None.Example:
Here is a sample album with a couple of tracks that were removed.
https://music.youtube.com/playlist?list=OLAK5uy_m9fhpjoINvcfPzPibD7EMBXxpG_8txoGM
@sigma67 commented on GitHub (Oct 19, 2020):
I'd say this is working as intended, but I think we can do better than that. My proposed solution would be to remove all items from the list which are missing either videoId or setVideoId, before sending the request. This would replace the following lines:
github.com/sigma67/ytmusicapi@bdbaada36a/ytmusicapi/mixins/playlists.py (L254-L256)Would this fix your issue?