[PR #618] [MERGED] get_album: fix invalid track list artists (#617) #675

Closed
opened 2026-02-27 23:01:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/618
Author: @czifumasa
Created: 7/11/2024
Status: Merged
Merged: 7/11/2024
Merged by: @sigma67

Base: mainHead: get_album_invalid_artists_fix


📝 Commits (1)

  • e0c51f2 get_album: fix invalid track list artists (#617)

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 ytmusicapi/parsers/playlists.py (+1 -2)

📄 Description

Fixed invalid artists info for get_album from https://github.com/sigma67/ytmusicapi/issues/617 issue.

Bug was a result of my changes in #612.

This is a flexColumn for an artist:

{
"musicResponsiveListItemFlexColumnRenderer": {
  "text": {},
 "displayPriority": "MUSIC_RESPONSIVE_LIST_ITEM_COLUMN_DISPLAY_PRIORITY_HIGH"
 }
}

it was skipped in parsing, because it did not have navigationEndpoint and text was empty. "Plays" column has been used as an artist instead. I removed empty text check. Now it will be used as unrecognized artist column. Then parse_song_artists method will return None and in the end in get_album method if artist track is None, then primary album artist will be used. So it will work exactly as in 1.7.3 and before.

Closes #617.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/618 **Author:** [@czifumasa](https://github.com/czifumasa) **Created:** 7/11/2024 **Status:** ✅ Merged **Merged:** 7/11/2024 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `get_album_invalid_artists_fix` --- ### 📝 Commits (1) - [`e0c51f2`](https://github.com/sigma67/ytmusicapi/commit/e0c51f2717cc323e971d81a79fea3daaaa026224) get_album: fix invalid track list artists (#617) ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ytmusicapi/parsers/playlists.py` (+1 -2) </details> ### 📄 Description Fixed invalid artists info for get_album from https://github.com/sigma67/ytmusicapi/issues/617 issue. Bug was a result of my changes in #612. This is a flexColumn for an artist: ```javascript { "musicResponsiveListItemFlexColumnRenderer": { "text": {}, "displayPriority": "MUSIC_RESPONSIVE_LIST_ITEM_COLUMN_DISPLAY_PRIORITY_HIGH" } } ``` it was skipped in parsing, because it did not have `navigationEndpoint` and `text` was empty. "Plays" column has been used as an artist instead. I removed empty `text` check. Now it will be used as unrecognized artist column. Then `parse_song_artists` method will return `None` and in the end in `get_album` method if artist track is `None`, then primary album artist will be used. So it will work exactly as in 1.7.3 and before. Closes #617. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:01:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ytmusicapi#675
No description provided.