mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 15:26:01 +03:00
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#672
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/sigma67/ytmusicapi/pull/612
Author: @czifumasa
Created: 6/30/2024
Status: ✅ Merged
Merged: 7/3/2024
Merged by: @sigma67
Base:
main← Head:fix_collaborative_playlists📝 Commits (3)
abb6ba7get_playlist: title, artists and album are correctly resolved in collaborative playlists (#603)c1a8713Merge branch 'main' into czifumasa-fix_collaborative_playlists4207444Merge branch 'main' into czifumasa-fix_collaborative_playlists📊 Changes
1 file changed (+54 additions, -10 deletions)
View changed files
📝
ytmusicapi/parsers/playlists.py(+54 -10)📄 Description
Fixed invalid playlist item info for collaborative playlists from #603 issue.
Instead of hardcoded indexes for flexColumns, now they are resolved using their navigationEndpoint with following logic:
watchEndpoint-> titlebrowseEndpointwithpageType == MUSIC_PAGE_TYPE_ALBUM-> albumbrowseEndpointwithpageType == MUSIC_PAGE_TYPE_ARTIST(Regular Artists) orpageType == MUSIC_PAGE_TYPE_UNKNOWN(Artists for uploaded songs)-> artistsbrowseEndpointwithpageType == MUSIC_PAGE_TYPE_USER_CHANNEL-> user channelAdditional checks:
Unavailable songs do not have navigationEndpoints so hardcoded indexes are still used. Collaborative user is not listed for unavailable song, so it should not be a problem.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.