[PR #567] [MERGED] adding Optional type hinting for limits ( fix #565 ) #655

Closed
opened 2026-02-27 23:01:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/567
Author: @code-instable
Created: 3/18/2024
Status: Merged
Merged: 3/20/2024
Merged by: @sigma67

Base: mainHead: documentation-typing-fix


📝 Commits (2)

📊 Changes

3 files changed (+7 additions, -5 deletions)

View changed files

📝 ytmusicapi/mixins/library.py (+1 -1)
📝 ytmusicapi/mixins/playlists.py (+1 -1)
📝 ytmusicapi/mixins/uploads.py (+5 -3)

📄 Description

Adding Optional typing for limit in methods whose documentation explicitly allows the use of None type for no limit. This fixes wrong error hinting in editors.

[ contribution requested in #565 ]


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/567 **Author:** [@code-instable](https://github.com/code-instable) **Created:** 3/18/2024 **Status:** ✅ Merged **Merged:** 3/20/2024 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `documentation-typing-fix` --- ### 📝 Commits (2) - [`42bab08`](https://github.com/sigma67/ytmusicapi/commit/42bab087ec6161ff15b02e4d7362726dc0f463d2) adding Optional type hinting for limits - [`a17c8f6`](https://github.com/sigma67/ytmusicapi/commit/a17c8f61da5d30b14d84bed26817dc8124cff370) format ### 📊 Changes **3 files changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `ytmusicapi/mixins/library.py` (+1 -1) 📝 `ytmusicapi/mixins/playlists.py` (+1 -1) 📝 `ytmusicapi/mixins/uploads.py` (+5 -3) </details> ### 📄 Description Adding Optional typing for limit in methods whose documentation explicitly allows the use of None type for no limit. This fixes wrong error hinting in editors. [ contribution requested in #565 ] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:01:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ytmusicapi#655
No description provided.