mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 07:16:00 +03:00
[PR #523] [MERGED] get_album: parse more data from response + correct keys on other_vers… #636
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#636
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/sigma67/ytmusicapi/pull/523
Author: @jcbirdwell
Created: 1/14/2024
Status: ✅ Merged
Merged: 1/21/2024
Merged by: @sigma67
Base:
main← Head:album-data-mining📝 Commits (4)
74434c7get_album: parse more data from response + correct keys on other_versionsdd552cdkeys: fair point10f91b5navigation, browsing: removed duplicate SUBTITLE10b0546Merge remote-tracking branch 'origin/main' into jcbirdwell-album-data-mining📊 Changes
4 files changed (+55 additions, -20 deletions)
View changed files
📝
tests/mixins/test_browsing.py(+38 -18)📝
ytmusicapi/navigation.py(+5 -2)📝
ytmusicapi/parsers/albums.py(+2 -0)📝
ytmusicapi/parsers/browsing.py(+10 -0)📄 Description
#522 + tests. I'll bet there's still more to be found, but I'm going cross eyed trying to read these response objects. This fixes the original issue of incorrect keys in "other_versions" and adds audio playlist id, artists with id and name, album type, removes year (I couldn't find it), and adds explicit to the main album requested in get_album.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.