mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 07:16:00 +03:00
[PR #516] [MERGED] get_album: track_number returns none when track unavailable + test #635
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#635
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/sigma67/ytmusicapi/pull/516
Author: @jcbirdwell
Created: 1/13/2024
Status: ✅ Merged
Merged: 1/14/2024
Merged by: @sigma67
Base:
main← Head:track_number_fix📝 Commits (3)
63cdcc1get_album: track_number returns none when track unavailable + test0cc590aUpdate ytmusicapi/parsers/playlists.pyad73362test_get_album: sans fixtures📊 Changes
3 files changed (+5 additions, -10 deletions)
View changed files
📝
tests/conftest.py(+0 -6)📝
tests/mixins/test_browsing.py(+4 -2)📝
ytmusicapi/parsers/playlists.py(+1 -2)📄 Description
Simple fix for #515 and adds test case for albums with unavailable tracks.
Issue could alternatively be solved by extending nav's none_if_absent to coerce nullish return values. thoughts?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.