[PR #517] [MERGED] Remove offset + fix top result #633

New issue

Closed

opened 2026-02-27 23:01:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:01:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/517
Author: @AustinGitHub
Created: 1/13/2024
Status: ✅ Merged
Merged: 1/14/2024
Merged by: @sigma67

Base: main ← Head: fix_top_results

📝 Commits (4)

55db498 Remove offset + fix top result
91254ce add Null checks
1efef81 Make updates per comments
62bafe1 Update ytmusicapi/parsers/search.py

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 ytmusicapi/parsers/search.py (+5 -2)

📄 Description

Issue - https://github.com/sigma67/ytmusicapi/issues/518
These offsets cause an issue

Fix, I test this way

Before
BeforeChange.txt

After
AfterChanges.txt

Differences

Only issue is this

But this is because code forced in to append None for artist without Id but then again, what if an artist name is "Album" can't just filter that out by keyword. I think this append of None should be taken out because with the way youtube music and youtube topic channels are auto-created I think it is safe to say most artists would have an id, no?

Let me know and I can commit that change, thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/517 **Author:** [@AustinGitHub](https://github.com/AustinGitHub) **Created:** 1/13/2024 **Status:** ✅ Merged **Merged:** 1/14/2024 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `fix_top_results` --- ### 📝 Commits (4) - [`55db498`](https://github.com/sigma67/ytmusicapi/commit/55db498b744ae13cef879f481f7fb25229cd1a98) Remove offset + fix top result - [`91254ce`](https://github.com/sigma67/ytmusicapi/commit/91254ce5e248ba7170d28b46166ec20d72b83c19) add Null checks - [`1efef81`](https://github.com/sigma67/ytmusicapi/commit/1efef81128ae89f48cdf258e368471c6b9c0b016) Make updates per comments - [`62bafe1`](https://github.com/sigma67/ytmusicapi/commit/62bafe1830a287e2c036dfebef076f314d3ca83f) Update ytmusicapi/parsers/search.py ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ytmusicapi/parsers/search.py` (+5 -2) </details> ### 📄 Description Issue - https://github.com/sigma67/ytmusicapi/issues/518 These offsets cause an issue Fix, I test this way ![image](https://github.com/sigma67/ytmusicapi/assets/10100397/dca578ff-37e6-4f9f-9194-e367ae0a1072) Before [BeforeChange.txt](https://github.com/sigma67/ytmusicapi/files/13929569/BeforeChange.txt) After [AfterChanges.txt](https://github.com/sigma67/ytmusicapi/files/13929572/AfterChanges.txt) Differences ![image](https://github.com/sigma67/ytmusicapi/assets/10100397/ed78822e-e3aa-43c1-bee6-98b13c051778) Only issue is this ![image](https://github.com/sigma67/ytmusicapi/assets/10100397/70a566dd-0010-484a-a905-81583a7362c3) But this is because code forced in to append `None` for artist without `Id` but then again, what if an artist name is "Album" can't just filter that out by keyword. I think this append of `None` should be taken out because with the way youtube music and youtube topic channels are auto-created I think it is safe to say most artists would have an id, no? Let me know and I can commit that change, thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>