[PR #510] [MERGED] Track positions #631

New issue

Closed

opened 2026-02-27 23:01:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:01:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/510
Author: @jcbirdwell
Created: 1/9/2024
Status: ✅ Merged
Merged: 1/11/2024
Merged by: @sigma67

Base: main ← Head: track_positions

📝 Commits (7)

9753528 ytmusicapi: relative module imports
8e2ab98 get_album (via parse_playlist_items): add track_position key + tests for the badly indexed album
046134f relative imports: uno_reverse
3aa5227 get_album & parse_playlist_items: nav changes
9d65913 parse_playlist_items: only add track_position for albums
0aff162 parse_playlist_items & related test_browsing: track_position > track_number
ec82396 Merge remote-tracking branch 'origin/main' into jcbirdwell-track_positions

📊 Changes

4 files changed (+18 additions, -3 deletions)

View changed files

📝 tests/conftest.py (+6 -0)
📝 tests/mixins/test_browsing.py (+5 -1)
📝 ytmusicapi/mixins/browsing.py (+1 -1)
📝 ytmusicapi/parsers/playlists.py (+6 -1)

📄 Description

Implementation of #509.

I refactored to relative imports so I could get proper module linking to track down the required functions.

All relevant tests passing + new tests added for the weird album.

I was unsure if the album's browseId should be made a fixture or just added inline for the individual test as there seems to be both.

I'm getting some weird behavior with the new ruff/mypy pipeline related to library stubs that I can't seem to get working at the moment, but I think the errors are irrelevant to the PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/510 **Author:** [@jcbirdwell](https://github.com/jcbirdwell) **Created:** 1/9/2024 **Status:** ✅ Merged **Merged:** 1/11/2024 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `track_positions` --- ### 📝 Commits (7) - [`9753528`](https://github.com/sigma67/ytmusicapi/commit/9753528b535af90ce02f4921144e20878dc20de5) ytmusicapi: relative module imports - [`8e2ab98`](https://github.com/sigma67/ytmusicapi/commit/8e2ab98959bedfb8f108f5eb72551bc043943939) get_album (via parse_playlist_items): add track_position key + tests for the badly indexed album - [`046134f`](https://github.com/sigma67/ytmusicapi/commit/046134fa764f82060d0a5ebbc82215b374870139) relative imports: uno_reverse - [`3aa5227`](https://github.com/sigma67/ytmusicapi/commit/3aa5227d6cc473d9440bdd488c146f07da10d025) get_album & parse_playlist_items: nav changes - [`9d65913`](https://github.com/sigma67/ytmusicapi/commit/9d65913bfd2f1a639d9fbb591e0329e8a8e5479f) parse_playlist_items: only add track_position for albums - [`0aff162`](https://github.com/sigma67/ytmusicapi/commit/0aff1621ca0ceaebbf194f0f5b81386a17fa5eaf) parse_playlist_items & related test_browsing: track_position > track_number - [`ec82396`](https://github.com/sigma67/ytmusicapi/commit/ec823967acceceefbfa247aa33cc102acca23c70) Merge remote-tracking branch 'origin/main' into jcbirdwell-track_positions ### 📊 Changes **4 files changed** (+18 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tests/conftest.py` (+6 -0) 📝 `tests/mixins/test_browsing.py` (+5 -1) 📝 `ytmusicapi/mixins/browsing.py` (+1 -1) 📝 `ytmusicapi/parsers/playlists.py` (+6 -1) </details> ### 📄 Description Implementation of #509. I refactored to relative imports so I could get proper module linking to track down the required functions. All relevant tests passing + new tests added for the weird album. - I was unsure if the album's browseId should be made a fixture or just added inline for the individual test as there seems to be both. I'm getting some weird behavior with the new ruff/mypy pipeline related to library stubs that I can't seem to get working at the moment, but I think the errors are irrelevant to the PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>