[PR #396] [MERGED] Add external OAuth case to browser check #607

Closed
opened 2026-02-27 23:01:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/396
Author: @MarvinSchenkel
Created: 5/28/2023
Status: Merged
Merged: 6/15/2023
Merged by: @sigma67

Base: masterHead: master


📝 Commits (3)

  • 7298bc5 Add external OAuth case to browser check.
  • f1e50dc Remove check to outer scope..
  • f5772a0 Remove check to outer scope..

📊 Changes

2 files changed (+9 additions, -1 deletions)

View changed files

📝 ytmusicapi/auth/headers.py (+4 -1)
📝 ytmusicapi/auth/oauth.py (+5 -0)

📄 Description

Hi 👋 ,

I use this project as a dependency for a project where I retrieve an OAuth token myself and set it on the headers to authenticate. Since version 1.0.1 this started failing, because this method is not recognized as either browser_auth or oauth.

This PR extends the browser check to make sure that the Authorization value is an OAuth token in case no Cookie is supplied.

Regards,
Marvin


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/396 **Author:** [@MarvinSchenkel](https://github.com/MarvinSchenkel) **Created:** 5/28/2023 **Status:** ✅ Merged **Merged:** 6/15/2023 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`7298bc5`](https://github.com/sigma67/ytmusicapi/commit/7298bc51953fe32fb9c51f84f0746d64e94eabde) Add external OAuth case to browser check. - [`f1e50dc`](https://github.com/sigma67/ytmusicapi/commit/f1e50dc4c3c8cf9f6fb54897a9819c92fb084372) Remove check to outer scope.. - [`f5772a0`](https://github.com/sigma67/ytmusicapi/commit/f5772a036cff13dc79cef8a63a922c6f131e608b) Remove check to outer scope.. ### 📊 Changes **2 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ytmusicapi/auth/headers.py` (+4 -1) 📝 `ytmusicapi/auth/oauth.py` (+5 -0) </details> ### 📄 Description Hi 👋 , I use this project as a dependency for a project where I retrieve an OAuth token myself and set it on the headers to authenticate. Since version 1.0.1 this started failing, because this method is not recognized as either browser_auth or oauth. This PR extends the browser check to make sure that the `Authorization` value is an OAuth token in case no `Cookie` is supplied. Regards, Marvin --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:01:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ytmusicapi#607
No description provided.