mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 23:36:00 +03:00
[PR #309] [MERGED] Remove quotes from cookies #597
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#597
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/sigma67/ytmusicapi/pull/309
Author: @JohnHKoh
Created: 10/13/2022
Status: ✅ Merged
Merged: 11/3/2022
Merged by: @sigma67
Base:
master← Head:remove-cookie-quotes📝 Commits (1)
b3547a9Remove quotes from cookies📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
ytmusicapi/helpers.py(+1 -1)📄 Description
Due to the SimpleCookie issue described here, cookies are not properly parse when they include quotes. As the "YT_CL" cookie includes quotes, this breaks the cookie parser and throws the following exception:
While one solution is to completely re-write the cookie parser to fix this issue, a much simpler one may be to just remove quotes from cookies altogether. Authentication succeeds after removing the quotes from the cookies.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.