mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 15:26:01 +03:00
[PR #181] [MERGED] Feature: Related Artists in get_artist and Exception for Non-Music Channels #574
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#574
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/sigma67/ytmusicapi/pull/181
Author: @tempoxylophone
Created: 3/22/2021
Status: ✅ Merged
Merged: 3/24/2021
Merged by: @sigma67
Base:
master← Head:master📝 Commits (7)
5457cd8Feature: add related artist section to BrowsingMixin get_artist method3272e1fadded documentation for related artists featureb1ecae3removed named exception in favor of ValueError when non-music YouTube channel id given to get_artist. Minor changes to structure of related artists property in get_artist, added thumbnails.15bf0bbFeature: add related artist section to BrowsingMixin get_artist method27a12e6added documentation for related artists feature8ec9b6aremoved named exception in favor of ValueError when non-music YouTube channel id given to get_artist. Minor changes to structure of related artists property in get_artist, added thumbnails.c40cb12Merge branch 'master' of https://github.com/mikefreemanwd/ytmusicapi📊 Changes
4 files changed (+60 additions, -7 deletions)
View changed files
📝
README.rst(+1 -1)📝
tests/test.py(+16 -1)📝
ytmusicapi/mixins/browsing.py(+33 -5)📝
ytmusicapi/parsers/browsing.py(+10 -0)📄 Description
In the
BrowserMixinclass from the mixins/browsing.py file there is a method calledget_artistthat returns artist information.I made 2 modifications to
get_artist:YouTubeChannelIDIsNotArtistExceptionthat is thrown when a non-music channel ID is provided to theget_artistfunction.I updated the documentation for the
get_artistfunction, added a unit test for each modification, and made sure that the pre-commit linters pass.This can be called with:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.