mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 15:26:01 +03:00
[PR #194] [CLOSED] minor checks for list values to prevent errors #573
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#573
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/sigma67/ytmusicapi/pull/194
Author: @jskills
Created: 4/26/2021
Status: ❌ Closed
Base:
master← Head:list-val-checks📝 Commits (1)
5e3b6faminor checks for list values to prevent errors📊 Changes
2 files changed (+4 additions, -4 deletions)
View changed files
📝
ytmusicapi/parsers/browsing.py(+3 -3)📝
ytmusicapi/parsers/utils.py(+1 -1)📄 Description
This may be specific to those who have imported Google Play Music libraries into Youtube Music. As meticulous as I have been about ensuring all songs have the minimum mp3 tags (song title , artist and genre) as well as "album" wherever possible, I have seen results come back from ytmusicapi searches on "uploads" where the artist or album is missing and cause parsers/browsing.py or parsers/utils.py throw errors. These searches on the same terms work and return results in Youtube Music in the browser.
These minor additions ensure we're checking for values in Python list structures in some cases where they're assumed to be there. These changes just make for more graceful performance when encountering data that is expected to be present, but may not be.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.