mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 07:16:00 +03:00
[PR #108] [CLOSED] Retreive streaming data for 256 kbps AAC #561
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#561
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/sigma67/ytmusicapi/pull/108
Author: @corrmaan
Created: 11/24/2020
Status: ❌ Closed
Base:
master← Head:audio_quality_high📝 Commits (6)
dd19babRetreive streaming data for 256 kbps AACf430e0bSplitget_streamingData()off ofget_song()a59439bRenameget_streamingData()toget_streaming_data()ef4bd11Documentation and tests updated4e0cfdAdjust variable name for proper naming conventiondf29c09Edit toget_streaming_data()test📊 Changes
3 files changed (+105 additions, -28 deletions)
View changed files
📝
docs/source/reference.rst(+1 -0)📝
tests/test.py(+5 -1)📝
ytmusicapi/mixins/browsing.py(+99 -27)📄 Description
Adding the parameters
c=WEB_REMIXandcver=0.1to theget_video_inforequest inget_song()returns astreamingDataadaptiveFormatofitag141,audioQualityofAUDIO_QUALITY_HIGH, a 256 kbps AAC m4a for authenticated requests from YouTube Music Premium subscribers.Unfortunately, these parameters result in
player_response['videoDetails']['shortDescription']not being returned, the information in which contains useful song metadata.player_response['microformat']['microformatDataRenderer']['description']is returned, but it seems to be a truncated version ofshortDescription, so the metadata parsing inget_song()does not work on that response.Therefore, a second
get_video_inforequest is made with the updated parameters and the metadata insong_metais copied in to the newplayer_response['videoDetails'], which is returned fromget_song()instead ofsong_meta.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.