[PR #93] [CLOSED] Fix/apikey #555

New issue

Closed

opened 2026-02-27 23:01:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:01:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/93
Author: @natumbri
Created: 10/28/2020
Status: ❌ Closed

Base: master ← Head: fix/apikey

📝 Commits (3)

b3b0ece detect API key
81501c0 back to original
d978ebb complete pre-commit tasks

📊 Changes

1 file changed (+66 additions, -32 deletions)

View changed files

📝 ytmusicapi/ytmusic.py (+66 -32)

📄 Description

I wonder if the issue arising in #62 might relate to the API key that is included in params?

In his effort at implementing the YouTube music api, @DonnieWest's version grabs the key value dynamically. Perhaps this would be an improvement for your version? (Original code from @DonnieWest here: https://github.com/DonnieWest/mopidy-youtube/tree/youtubeMusic)

I've had a go at implementing it. In _send_request I didn't know what additionalParams is for, so ... I just left it out of my implementation(!). If it is important, instead of a string that is added to the requests.post url parameter, it could be passed to requests.post as part of the body dict?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/93 **Author:** [@natumbri](https://github.com/natumbri) **Created:** 10/28/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/apikey` --- ### 📝 Commits (3) - [`b3b0ece`](https://github.com/sigma67/ytmusicapi/commit/b3b0ece6616ed10d2f00bd1d9c79f49860b432e3) detect API key - [`81501c0`](https://github.com/sigma67/ytmusicapi/commit/81501c00438a720fe95742b270d6ac9665358c9b) back to original - [`d978ebb`](https://github.com/sigma67/ytmusicapi/commit/d978ebbf9676181c36139b8e14de895bfa3cac27) complete pre-commit tasks ### 📊 Changes **1 file changed** (+66 additions, -32 deletions) <details> <summary>View changed files</summary> 📝 `ytmusicapi/ytmusic.py` (+66 -32) </details> ### 📄 Description I wonder if the issue arising in #62 might relate to the API key that is included in `params`? In his effort at implementing the YouTube music api, @DonnieWest's version grabs the `key` value dynamically. Perhaps this would be an improvement for your version? (Original code from @DonnieWest here: https://github.com/DonnieWest/mopidy-youtube/tree/youtubeMusic) I've had a go at implementing it. In `_send_request` I didn't know what `additionalParams` is for, so ... I just left it out of my implementation(!). If it is important, instead of a string that is added to the `requests.post` `url` parameter, it could be passed to `requests.post` as part of the `body` dict? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>