mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-26 15:56:00 +03:00
[GH-ISSUE #627] get_playlist track artists are now None #428
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#428
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ghost on GitHub (Jul 17, 2024).
Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/627
Describe the bug
In version 1.7.5, the value of
artistsin alltracksitems inget_playlist()data is alwaysNone. This is not the case in 1.7.4.To Reproduce
Additional context
1.7.4:
1.7.5:
Because of this there is no way to get artist information from a playlist in 1.7.5.
@czifumasa commented on GitHub (Jul 17, 2024):
So yet another case, that I have to adapt to the new logic, this time it's videos uploaded from non-official user channels. I guess initially in 1.7.4 it worked, but then I fixed albums (#618) and I broke this one.
I will revert my fix from #618 and I will remove the new logic for albums, bringing back preset flexColumn meanings.
What do you think? @sigma67
P.S. I know we need tests for all these cases, but tbh I am not sure how to design them.
@sigma67 commented on GitHub (Jul 18, 2024):
Reverting the fix won't help because then you break the other use cases again.
Good tests would be to add asserts on the existing tests. For all tests with static album and playlist ids (where tracks are known to have artists), add an assert that ensures the artist is parsed correctly
@czifumasa commented on GitHub (Jul 18, 2024):
What I meant is removing the new logic, but only for albums (see: 3208ca9). So for albums columns are hardcoded and for playlist they are still resolved using
navigationEndpoints.There are border cases with columns without
navigationEndpoint, where I have to guess their meaning. Those cases are different for albums and for playlists, so I cannot use the same logic for both methods. Albums always have the same order offlexColumns, so dynamic resolving is not needed there.@sigma67 commented on GitHub (Jul 18, 2024):
I see, that's fine. Please also consider the
suggestionskey inget_playlistin your tests (although I'm not sure why it should behave differently - maybe it doesn't)