mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 07:16:00 +03:00
[GH-ISSUE #483] Search has weird albums #359
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#359
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @polvallverdu on GitHub (Dec 7, 2023).
Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/483
Originally assigned to: @polvallverdu on GitHub.
Describe the bug
I've been running an automated application with this library (my async version), and the only flagging that I get is a report that some albums are considered songs (ytmusic doesn't even recognize these as albums, as I mentioned in a past issue), but from the app I can access the album, so there should be a way to get the album id. This occurs when searching without any filter.
Here's what I'm talking about:
When searching for "supernova saiko", this album appears without album id, but a track also appears containing the actual albumid. That's why I call it weird album.
To Reproduce
Steps to reproduce the behavior:
@theyak commented on GitHub (Dec 8, 2023):
Agreed. I think the issue lies in the search parser.
What is happening is that it's looking to see if it has a video type, and if it does, it assumes song or video. I think checking
get_item_text(data, 1)for a value ofsingleoralbum(might need some language processing) before checking the video type would fix this issue.@sigma67 commented on GitHub (Dec 13, 2023):
PR welcome
@polvallverdu commented on GitHub (Dec 13, 2023):
I'm looking to test it and PR of Friday
@polvallverdu commented on GitHub (Dec 15, 2023):
Thank you @theyak for the comment. I just made that result_type can be also album if being None.
@sigma67 commented on GitHub (Dec 31, 2023):
I'm failing to reproduce this, please provide better instructions. There are no
category="Albums"results for me on the provided search term.@polvallverdu commented on GitHub (Jan 6, 2024):
Can it be because I'm using an account with Youtube Premium?
@sigma67 commented on GitHub (Jan 12, 2024):
I pushed a fix for album top results in
16c9cbe, but I'm not sure it addresses your issueCan you provide a good search term to reproduce again? "supernova saiko" is not reproducing for me