mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 15:26:01 +03:00
[GH-ISSUE #480] get_artist returns different channelId for some artists #357
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#357
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Schtenk on GitHub (Nov 28, 2023).
Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/480
You missunderstand me in both #477 and #479.
What im saying is and that the channelId parsed from the get_artist response is the wrong one so if used again in with get_artist no songs are returned, as the links clearly shows.
sorry for trying to help, I wont make more issues.
@sigma67 commented on GitHub (Nov 28, 2023):
You know you can just reopen the issue or comment below.
If you followed the issue template it would be much easier to reproduce your issue. Here it is again:
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Additional context
Add any other context about the problem here, such as a code sample.
@Schtenk commented on GitHub (Nov 28, 2023):
Tried to comment but for some reason I couldn't.
It isn't necessarily a bug depending on what channel id you want, which is why I didn't create a bug report specifically.
I just wanted to point out based on the comment in the code:
if 'musicShelfRenderer' in results[0]: # API sometimes does not return songsin mixin/browsing.py row:235that using the channelId saved in the code:
artist['channelId'] = subscription_button['channelId']in in mixin/browsing.py row:224with get_artist will not return any songs, and that it may be the answer why the issue the comment refers to happens.
@sigma67 commented on GitHub (Dec 18, 2023):
I mean yes, I guess this is a valid issue.
On the other hand, when you're calling
get_artistyou already have thechannelBrowseId. So isn't it more useful to return thechannelIdfrom the subscribeButton in that case?@Schtenk commented on GitHub (Dec 18, 2023):
Sure, may just be a naming/documentation issue where both are called
channelId. It should rarely be a problem but if a user saves the subscribe one for later thinking they are the same, may then lead to the issue occuring.Only the
channelIdunder the subscribe button can be used for subscribing if i remember correctly, so it is usefull.@sigma67 commented on GitHub (Dec 19, 2023):
Renaming the key is difficult since it would break backwards compatibility. In light of this
subscriptionChannelIdwould be the better name. I think we can add it to the docstring?