mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 15:26:01 +03:00
[GH-ISSUE #454] feedbackTokens add and remove are swapped #337
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#337
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adamhl8 on GitHub (Oct 9, 2023).
Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/454
It seems like the
addandremovekeys are swapped infeedbackTokens.As you can see I get
Added to library. I also checked YTM and the track is still there.If I instead get the
addtoken:Which does actually remove the track from YTM.
@sigma67 commented on GitHub (Oct 9, 2023):
That must be a bug. Are you sure that's what's happening and not some problem with your code?
For reference, this function has been unchanged for two years.
github.com/sigma67/ytmusicapi@05a5fb8153/ytmusicapi/parsers/songs.py (L65-L79)@adamhl8 commented on GitHub (Oct 9, 2023):
I posted my code verbatim. What's the purpose of swapping the tokens on
71? I assume that's what's causing the behavior I'm seeing.@sigma67 commented on GitHub (Oct 24, 2023):
Yeah sorry this was buggy. I also added a
inLibraryflag now to indicate the current status