mirror of
https://github.com/sigma67/ytmusicapi.git
synced 2026-04-25 23:36:00 +03:00
[GH-ISSUE #374] filtering search on albums is not filtered? #296
Labels
No labels
a/b
bug
documentation
enhancement
good first issue
help wanted
invalid
pull-request
question
wontfix
yt-error
yt-update
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ytmusicapi#296
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @zeitmeister on GitHub (Apr 5, 2023).
Original GitHub issue: https://github.com/sigma67/ytmusicapi/issues/374
When performing a search with "albums" as filter i get a different response when i run my code locally compared to when i run it in a docker container.
The following search is perfomed:
ytmusic.search("Sepultura Arise", "albums")And the response from when I run it locally is:
The response from the same request made from within a docker container:
Note that the
resultTypeis different and the absence of browseId (which breaks my whole app).I discovered the issue when working on a "bigger" playlist app and decided to do a minimal test and the issue is still there. The minimal code for reproducing the error :
And the Dockerfile:
This well might not be a problem with
ytmusicapibut instead with docker networking somehow but then wouldn't it be no request at all? I'm trying to wrap my head around what is actually happening here but can't quite figure it out. I wouldn't be suprised if I missed something. Sorry about the long entry.Thanks for a great service anyhow!
Kind regards
Simon
@zeitmeister commented on GitHub (Apr 5, 2023):
Ok, I figured out that everytime I rebuild and run the docker container the newest version of ytmusicapi is installed (since the
pip installline in the Dockerfile and that it's been a while since i did it locally. When i updated ytmusicapi locally (from 0.25.0 to 0.25.2 i got the same response as i did from the docker container. The problem still remains though, I am filtering on"albums"and I expect the response to be filtered like that. Is this a proper issue or is it still something I don't understand? : )@sigma67 commented on GitHub (Apr 5, 2023):
It is indeed a bug. Something about the obscure filtering params used in search seems to have changed.
@sigma67 commented on GitHub (Apr 5, 2023):
It works for me with the change above. Did you notice any other oddities about search?
@zeitmeister commented on GitHub (Apr 6, 2023):
All right! No, I'm actually just using album searching so I haven't noticed anything else with the search functionality. Is there anyway i could try these changes out?
@sigma67 commented on GitHub (Apr 6, 2023):
pip install git+https://github.com/sigma67/ytmusicapi@zeitmeister commented on GitHub (Apr 6, 2023):
Sorry but this command installs the package as
UNKNOWNand I am too much of a python newbie to know how to make this work.from UNKOWN import YTMusicdoes not do the trick unfortunately.@sigma67 commented on GitHub (Apr 6, 2023):
Not sure why, I get
Successfully installed ytmusicapi-0.25.3.dev19+ga1e4662What's your pip output?
@zeitmeister commented on GitHub (Apr 6, 2023):
my python version is 3.10.6
and pip is 22.0.2
I've also tried with
sudowith same result. Also tried the-eflag (which is some edit mode for renaming and stuff, I really have no idea what it does) but got:ERROR: Project ytmusicapi from git+https://github.com/sigma67/ytmusicapi#egg=ytmusicapi has a 'pyproject.toml' and its build backend is missing the 'build_editable' hook. Since it does not have a 'setup.py' nor a 'setup.cfg', it cannot be installed in editable mode. Consider using a build backend that supports PEP 660.@zeitmeister commented on GitHub (Apr 6, 2023):
Sorry for being a complete idiot. Upgrading pip made me able to run the updated ytmusicapi. fml...
@sigma67 commented on GitHub (Apr 6, 2023):
Good to know though, should specify pip > 23 somewhere I guess
@zeitmeister commented on GitHub (Apr 6, 2023):
Yeah, I suppose. But even now when I'm using
ytmusicapi 0.25.3.dev19+ga1e4662as stated when I'm runningpip listi still get the same none album response when filtering for albums. TheresultTypeis all of the valuesong@sigma67 commented on GitHub (Apr 6, 2023):
I have to apologize, that was an oversight on my part. It wasn't actually the parameter, the old one worked fine.
I added some more asserts as well to prevent this in the future.
@zeitmeister commented on GitHub (Apr 7, 2023):
All right, no worries! It seems to be working now. Thank you so much for your quick responses!