starred/xshok-proxmox
1
0
Fork 0
mirror of https://github.com/extremeshok/xshok-proxmox.git synced 2026-04-25 13:45:48 +03:00
Code Issues 12 Projects Releases Packages Wiki Activity

[GH-ISSUE #8] install-post.sh bug #5

New issue
Closed
opened 2026-02-27 01:57:18 +03:00 by kerem · 4 comments
kerem commented 2026-02-27 01:57:18 +03:00
Owner
Copy link

Originally created by @stirch on GitHub (Feb 26, 2019).
Original GitHub issue: https://github.com/extremeshok/xshok-proxmox/issues/8

Hi!
This script failed with such error on fresh installed proxmox

Executing: /lib/systemd/systemd-sysv-install enable fail2ban
vm.swappiness = 10
vm.swappiness = 10
vm.min_free_kbytes = 524288
install-post.sh: line 334: syntax error: unexpected end of file

After removing from script the part about ## Pretty MOTD BANNER all working how intended

Originally created by @stirch on GitHub (Feb 26, 2019). Original GitHub issue: https://github.com/extremeshok/xshok-proxmox/issues/8 Hi! This script failed with such error on fresh installed proxmox ------------- Executing: /lib/systemd/systemd-sysv-install enable fail2ban vm.swappiness = 10 vm.swappiness = 10 vm.min_free_kbytes = 524288 install-post.sh: line 334: syntax error: unexpected end of file ------------------ After removing from script the part about ## Pretty MOTD BANNER all working how intended
kerem closed this issue 2026-02-27 01:57:19 +03:00
kerem commented 2026-02-27 01:57:19 +03:00
Author
Owner
Copy link

@JOduMonT commented on GitHub (Apr 15, 2019):

@Orfeous could you decompose the script and run command by command those
because it is the way I'm doing it and I don't any have error but as @stirch mentioned I also don't execute the MOTD BANNER

<!-- gh-comment-id:483447898 --> @JOduMonT commented on GitHub (Apr 15, 2019): @Orfeous could you decompose the script and run command by command those because it is the way I'm doing it and I don't any have error but as @stirch mentioned I also don't execute the MOTD BANNER
kerem commented 2026-02-27 01:57:19 +03:00
Author
Owner
Copy link

@Orfeous commented on GitHub (Apr 16, 2019):

@jodumont Sure, will do that.
To bypass the issue i just basically trashed out the whole MOTD part from the script.
For the first look it seems like an identication issue around EOF for the file contents. For some reason the script thinks that one is its own EOF and fails on it.

I'll show you my version and if you like it i create a pr as well.

<!-- gh-comment-id:483643510 --> @Orfeous commented on GitHub (Apr 16, 2019): @jodumont Sure, will do that. To bypass the issue i just basically trashed out the whole MOTD part from the script. For the first look it seems like an identication issue around EOF for the file contents. For some reason the script thinks that one is its own EOF and fails on it. I'll show you my version and if you like it i create a pr as well.
kerem commented 2026-02-27 01:57:19 +03:00
Author
Owner
Copy link

@extremeshok commented on GitHub (Apr 27, 2019):

@Orfeous please create a PR or post the code change here.

Thanks

<!-- gh-comment-id:487274527 --> @extremeshok commented on GitHub (Apr 27, 2019): @Orfeous please create a PR or post the code change here. Thanks
kerem commented 2026-02-27 01:57:20 +03:00
Author
Owner
Copy link

@Orfeous commented on GitHub (May 1, 2019):

It gave me some headache because i wanted to fix it by keeping the script indentation intact.

At the end i gave up and just "break it" by removing it and adding some space to fix the here-document part. See #10

Now it works. :)

<!-- gh-comment-id:488407953 --> @Orfeous commented on GitHub (May 1, 2019): It gave me some headache because i wanted to fix it by keeping the script indentation intact. At the end i gave up and just "break it" by removing it and adding some space to fix the here-document part. See #10 Now it works. :)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dev
No results found.
Labels
Clear labels   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/xshok-proxmox#5
No description provided.