mirror of
https://github.com/debloper/xiosk.git
synced 2026-04-26 21:35:51 +03:00
[PR #84] Advanced chromium control -> No more keyboard shortcut emulation #95
Labels
No labels
bug
bug
documentation
enhancement
enhancement
feature request
good first issue
good first issue
help wanted
invalid
priority: high
priority: low
priority: medium
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/xiosk#95
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/debloper/xiosk/pull/84
Author: @remco-k
Created: 5/27/2025
Status: 🔄 Open
Base:
main← Head:adv-chromium-control📝 Commits (2)
0d29a63fix(runner): removed --enable-low-end-device-mode for better picture quality on a Pi4c3bf788feat(switcher): control Chromium directly via its debugging port, instead of using keyboard shortcuts📊 Changes
5 files changed (+67 additions, -5 deletions)
View changed files
➕
scripts/chromium-next-tab.sh(+37 -0)➕
scripts/chromium-reload-tab.py(+25 -0)📝
scripts/runner.sh(+2 -2)📝
scripts/setup.sh(+1 -1)📝
scripts/switcher.sh(+2 -2)📄 Description
I've had more than once that Chromium can lose keyboard input focus due to:
This causes the kiosk mode to just get stuck on whatever page is showing until you Alt+Tab to it or click it to give it focus.
I've tried to implement various ways of making sure keyboard input focus stays at Chromium, so that Ctrl+Tab and Ctrl+R keep on working, regardless of what happens with the Raspberry GUI. Only to find out its all just not good enough or a nice solid, maintainable, understandable solution.
The only nice, proper and rocksolid solution I could think of was to completely abandon the keyboard shortcut usage. For that I implemented the use of the Chromium debugging port, via that port Chromium can be controlled in many different ways and more importantly: It doesn't matter if it has or hasn't keyboard input focus, because we're not using keyboard shortcuts anymore.
This results in a always working tab-switch. Even when Chromium is not having keyboard input focus. I think this will be a great change for this project as I can imagine that many people have this problem with their "PiOSK" that suddenly stops changing tabs.
A couple of remarks about this change:
--enable-low-end-device-modeoption from Chromium, as with that option the color depth was decreased significantly, making any picture look horrible. Tested on a Raspberry Pi 4b, looked good after that. Feel free to ignore this change.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.