[PR #143] [MERGED] fix the success message alert message bug #128

New issue

Closed

opened 2026-03-03 11:14:33 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 11:14:33 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debloper/xiosk/pull/143
Author: @parthsidpara
Created: 12/9/2025
Status: ✅ Merged
Merged: 12/9/2025
Merged by: @debloper

Base: main ← Head: fix/alert-message-bug

📝 Commits (1)

12bdfc3 fix the success message alert message bug

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 dashboard/script.js (+1 -1)

📄 Description

Bug:
success alert message is not getting removed from the dashboard after applying changes.

Cause:
In showStatus function, we check if the request was successful (status 200). If it is, we remove the alert-danger class and add alert-success.
However, the cleanup timer specifically looks for .alert-danger to remove it. Because the successful "Apply" message is now an .alert-success, the timer ignores it, and the message stays on screen.

Fix:
By using tmpErr.remove(), we remove that specific alert instance regardless of whether it is an error(red) or a success(green) message.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debloper/xiosk/pull/143 **Author:** [@parthsidpara](https://github.com/parthsidpara) **Created:** 12/9/2025 **Status:** ✅ Merged **Merged:** 12/9/2025 **Merged by:** [@debloper](https://github.com/debloper) **Base:** `main` ← **Head:** `fix/alert-message-bug` --- ### 📝 Commits (1) - [`12bdfc3`](https://github.com/debloper/xiosk/commit/12bdfc34ec4bb9cff7e7560a7d442113c9451fc5) fix the success message alert message bug ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `dashboard/script.js` (+1 -1) </details> ### 📄 Description Bug: success alert message is not getting removed from the dashboard after applying changes. Cause: In `showStatus` function, we check if the request was successful (status 200). If it is, we remove the `alert-danger` class and add `alert-success`. However, the cleanup timer specifically looks for `.alert-danger` to remove it. Because the successful "Apply" message is now an `.alert-success`, the timer ignores it, and the message stays on screen. Fix: By using `tmpErr.remove()`, we remove that specific alert instance regardless of whether it is an error(red) or a success(green) message. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>