[PR #139] [MERGED] Feature: restart system services instead of rebooting system #125

Closed
opened 2026-03-03 11:14:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/debloper/xiosk/pull/139
Author: @parthsidpara
Created: 11/13/2025
Status: Merged
Merged: 11/15/2025
Merged by: @debloper

Base: mainHead: refactor/service-restart-instead-of-reboot


📝 Commits (1)

  • 06487ca replace rebootSystem function in index.ts

📊 Changes

1 file changed (+19 additions, -13 deletions)

View changed files

📝 dashboard/index.ts (+19 -13)

📄 Description

This PR replaces the function rebootSystem() with a new function applyConfigChanges() in index.ts.
It restarts the piosk-runner.service and piosk-switcher.service instead of rebooting the whole system when changes are applied from the dashboard.
I've tested this update but there are 2 more changes to be made:

  • Add a visual indicator on the dashboard when services are restarting and the new config has not yet been applied. This is because we previously used command.spawn() and now we are using command.output with await.
  • The feature mentioned in #109 (terminate kiosk from dashboard) can also be included in this PR

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/debloper/xiosk/pull/139 **Author:** [@parthsidpara](https://github.com/parthsidpara) **Created:** 11/13/2025 **Status:** ✅ Merged **Merged:** 11/15/2025 **Merged by:** [@debloper](https://github.com/debloper) **Base:** `main` ← **Head:** `refactor/service-restart-instead-of-reboot` --- ### 📝 Commits (1) - [`06487ca`](https://github.com/debloper/xiosk/commit/06487cafe009988ec157f39cf0618c0de768ba35) replace rebootSystem function in index.ts ### 📊 Changes **1 file changed** (+19 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `dashboard/index.ts` (+19 -13) </details> ### 📄 Description This PR replaces the function `rebootSystem()` with a new function `applyConfigChanges()` in `index.ts`. It restarts the `piosk-runner.service` and `piosk-switcher.service` instead of rebooting the whole system when changes are applied from the dashboard. I've tested this update but there are 2 more changes to be made: - Add a visual indicator on the dashboard when services are restarting and the new config has not yet been applied. This is because we previously used `command.spawn()` and now we are using `command.output` with `await`. - The feature mentioned in #109 (terminate kiosk from dashboard) can also be included in this PR --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 11:14:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/xiosk#125
No description provided.