[PR #106] [MERGED] Fix: Ensure reboot works reliably #108

New issue

Closed

opened 2026-03-03 11:14:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 11:14:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/debloper/xiosk/pull/106
Author: @parthsidpara
Created: 8/30/2025
Status: ✅ Merged
Merged: 9/2/2025
Merged by: @debloper

Base: main ← Head: fix/reboot-issue

📝 Commits (3)

b70220e fix stuck on reboot issue
7c75390 remove duplicate jq command
236383e spawn the reboot process in the rebootSystem function

📊 Changes

2 files changed (+21 additions, -6 deletions)

View changed files

📝 index.ts (+5 -5)
📝 scripts/runner.sh (+16 -1)

📄 Description

This PR fixes a critical bug that prevented the kiosk mode from launching correctly after applying settings from the dashboard.

Problem:
After applying settings from the dashboard, the Pi would reboot and get stuck on the Raspberry Pi logo splash screen, never launching the desktop or Chromium.

Solution:
runner.sh:

Export DISPLAY=:0 and XDG_RUNTIME_DIR=/run/user/$(id -u) to provide the necessary graphical context.
Add a guard clause to check if any URLs exist in the config, preventing Chromium from launching without URLs and allowing the script to exit gracefully.

index.ts:

The rebootSystem function is modified to use the absolute path /sbin/reboot
This is a universal and unambiguous path that does not depend on the PATH variable, ensuring the command works reliably in the systemd service environment.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/debloper/xiosk/pull/106 **Author:** [@parthsidpara](https://github.com/parthsidpara) **Created:** 8/30/2025 **Status:** ✅ Merged **Merged:** 9/2/2025 **Merged by:** [@debloper](https://github.com/debloper) **Base:** `main` ← **Head:** `fix/reboot-issue` --- ### 📝 Commits (3) - [`b70220e`](https://github.com/debloper/xiosk/commit/b70220e46d0b61be4e85f4dc3fd9448d1a6a5edd) fix stuck on reboot issue - [`7c75390`](https://github.com/debloper/xiosk/commit/7c75390f458231abe3557a8c4826e44592edaf7e) remove duplicate jq command - [`236383e`](https://github.com/debloper/xiosk/commit/236383e5e9ecad5fbee160389d112261304afbca) spawn the reboot process in the rebootSystem function ### 📊 Changes **2 files changed** (+21 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `index.ts` (+5 -5) 📝 `scripts/runner.sh` (+16 -1) </details> ### 📄 Description This PR fixes a critical bug that prevented the kiosk mode from launching correctly after applying settings from the dashboard. **Problem:** After applying settings from the dashboard, the Pi would reboot and get stuck on the Raspberry Pi logo splash screen, never launching the desktop or Chromium. **Solution:** `runner.sh`: - Export `DISPLAY=:0` and `XDG_RUNTIME_DIR=/run/user/$(id -u)` to provide the necessary graphical context. - Add a guard clause to check if any URLs exist in the config, preventing Chromium from launching without URLs and allowing the script to exit gracefully. `index.ts`: - The `rebootSystem` function is modified to use the absolute path `/sbin/reboot` - This is a universal and unambiguous path that does not depend on the PATH variable, ensuring the command works reliably in the systemd service environment. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>