[PR #38] [MERGED] feat: add background visibility toggle and improve overlay focus #59

Closed
opened 2026-03-03 15:57:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mrgoonie/winshot/pull/38
Author: @mrgoonie
Created: 12/12/2025
Status: Merged
Merged: 12/12/2025
Merged by: @mrgoonie

Base: devHead: goon


📝 Commits (4)

  • 76f6247 chore(release): bump version to 1.2.0-beta.3
  • 459ecfa Merge branch 'dev' into goon
  • 47869cd build: after pr from vivik
  • 39fadf3 feat: add background visibility toggle and improve overlay focus

📊 Changes

10 files changed (+90 additions, -23 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 frontend/dist/index.html (+2 -2)
📝 frontend/package.json.md5 (+1 -1)
📝 frontend/src/App.tsx (+33 -2)
📝 frontend/src/components/settings-panel.tsx (+39 -7)
📝 frontend/wailsjs/runtime/runtime.js (+0 -4)
📝 go.mod (+2 -2)
📝 go.sum (+4 -4)
📝 internal/overlay/overlay.go (+6 -0)
📝 package.json (+1 -1)

📄 Description

Summary

Add background visibility toggle to the Settings Panel with smart state management, and improve overlay window focus handling for better keyboard interaction.

Changes

  1. Background Visibility Toggle - New toggle button in SettingsPanel to show/hide decorative background
  2. Smart State Management - Automatically saves padding, corner radius, and output ratio when hiding background; restores values when showing
  3. Conditional Control Disabling - Corner Radius, Output Ratio, Gradient Presets, Custom Color, and Image Background controls are disabled when background is hidden
  4. Overlay Focus Improvement - Added SetForegroundWindow/SetFocus call to overlay window to enable proper Esc key handling for region capture cancellation
  5. Build Compatibility - Downgraded go-webview2 to v1.0.19 to fix Wails build compatibility issues

Files Modified

  • frontend/src/components/settings-panel.tsx - Background toggle UI and state management
  • frontend/src/App.tsx - Background state handling and control logic
  • internal/overlay/overlay.go - Focus window improvements
  • go.mod / go.sum - Updated go-webview2 dependency
  • .gitignore - Minor updates
  • package.json / package manifest files - Version bump

Test Plan

  • Toggle background visibility on/off and verify decorative elements hide/show correctly
  • Verify padding, corner radius, and output ratio values are saved when hiding background
  • Confirm these values are restored when showing background again
  • Check that Corner Radius, Output Ratio, Gradient, Color, and Image Background controls are disabled when background is off
  • Test Esc key functionality in overlay region selection with improved focus handling
  • Verify Wails build completes successfully with downgraded go-webview2 version

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mrgoonie/winshot/pull/38 **Author:** [@mrgoonie](https://github.com/mrgoonie) **Created:** 12/12/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@mrgoonie](https://github.com/mrgoonie) **Base:** `dev` ← **Head:** `goon` --- ### 📝 Commits (4) - [`76f6247`](https://github.com/mrgoonie/winshot/commit/76f6247f3dc1091b9ce0c10bcc582f7297f1251a) chore(release): bump version to 1.2.0-beta.3 - [`459ecfa`](https://github.com/mrgoonie/winshot/commit/459ecfac2442ec627bf18b5de85b3a62b00cb395) Merge branch 'dev' into goon - [`47869cd`](https://github.com/mrgoonie/winshot/commit/47869cd209cfb08e68da6d0f1bf77f5078c2b898) build: after pr from vivik - [`39fadf3`](https://github.com/mrgoonie/winshot/commit/39fadf3e59c211adc0d56f604266282302d8a80e) feat: add background visibility toggle and improve overlay focus ### 📊 Changes **10 files changed** (+90 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `frontend/dist/index.html` (+2 -2) 📝 `frontend/package.json.md5` (+1 -1) 📝 `frontend/src/App.tsx` (+33 -2) 📝 `frontend/src/components/settings-panel.tsx` (+39 -7) 📝 `frontend/wailsjs/runtime/runtime.js` (+0 -4) 📝 `go.mod` (+2 -2) 📝 `go.sum` (+4 -4) 📝 `internal/overlay/overlay.go` (+6 -0) 📝 `package.json` (+1 -1) </details> ### 📄 Description ## Summary Add background visibility toggle to the Settings Panel with smart state management, and improve overlay window focus handling for better keyboard interaction. ## Changes 1. **Background Visibility Toggle** - New toggle button in SettingsPanel to show/hide decorative background 2. **Smart State Management** - Automatically saves padding, corner radius, and output ratio when hiding background; restores values when showing 3. **Conditional Control Disabling** - Corner Radius, Output Ratio, Gradient Presets, Custom Color, and Image Background controls are disabled when background is hidden 4. **Overlay Focus Improvement** - Added SetForegroundWindow/SetFocus call to overlay window to enable proper Esc key handling for region capture cancellation 5. **Build Compatibility** - Downgraded go-webview2 to v1.0.19 to fix Wails build compatibility issues ## Files Modified - `frontend/src/components/settings-panel.tsx` - Background toggle UI and state management - `frontend/src/App.tsx` - Background state handling and control logic - `internal/overlay/overlay.go` - Focus window improvements - `go.mod` / `go.sum` - Updated go-webview2 dependency - `.gitignore` - Minor updates - `package.json` / package manifest files - Version bump ## Test Plan - [ ] Toggle background visibility on/off and verify decorative elements hide/show correctly - [ ] Verify padding, corner radius, and output ratio values are saved when hiding background - [ ] Confirm these values are restored when showing background again - [ ] Check that Corner Radius, Output Ratio, Gradient, Color, and Image Background controls are disabled when background is off - [ ] Test Esc key functionality in overlay region selection with improved focus handling - [ ] Verify Wails build completes successfully with downgraded go-webview2 version --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:57:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/winshot#59
No description provided.