starred/whos-on-my-network

Fork 0

mirror of https://github.com/brentvollebregt/whos-on-my-network.git synced 2026-04-25 03:25:51 +03:00

[GH-ISSUE #2] Urls do not resolve correctly. #3

New issue

Closed

opened 2026-02-26 12:22:20 +03:00 by kerem · 5 comments

kerem commented

2026-02-26 12:22:20 +03:00

Owner

Originally created by @m10653 on GitHub (Aug 9, 2021).
Original GitHub issue: https://github.com/brentvollebregt/whos-on-my-network/issues/2

So when using the web interface I noticed that everything worked fine when using the gui to navigate but as soon as you refreshed the page or sent the link of the page it would return a 404.

IE clicking scans brings you to /scans but if you refresh or navigate to /scans your get a 404.

Originally created by @m10653 on GitHub (Aug 9, 2021). Original GitHub issue: https://github.com/brentvollebregt/whos-on-my-network/issues/2 So when using the web interface I noticed that everything worked fine when using the gui to navigate but as soon as you refreshed the page or sent the link of the page it would return a 404. IE clicking scans brings you to /scans but if you refresh or navigate to /scans your get a 404.

kerem closed this issue

2026-02-26 12:22:20 +03:00

kerem commented

2026-02-26 12:22:20 +03:00

Author

Owner

@brentvollebregt commented on GitHub (Aug 10, 2021):

@m10653, could you checkout the latest on master and let me know if my latest changes have fixed the issue?

If so, I will create a new release.

@brentvollebregt commented on GitHub (Aug 10, 2021): @m10653, could you checkout the latest on master and let me know if my latest changes have fixed the issue? If so, I will create a new release.

kerem commented

2026-02-26 12:22:20 +03:00

Author

Owner

@m10653 commented on GitHub (Aug 11, 2021):

Will do. We just had a power outage so ill get back to you in a little bit.

@m10653 commented on GitHub (Aug 11, 2021): Will do. We just had a power outage so ill get back to you in a little bit.

kerem commented

2026-02-26 12:22:20 +03:00

Author

Owner

@m10653 commented on GitHub (Aug 15, 2021):

@brentvollebregt So testing most things work, but the following api endpoints fail.

/scans/#id
/devices/#id
/people/#id
all return a internal server error.

[2021-08-15 12:01:16,279] ERROR in app: Exception on /people/4 [GET]
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2070, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1515, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1513, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1499, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
TypeError: root() got an unexpected keyword argument 'id'

I tested the following urls and they work correctly:
/scans
/devices
/people
/current

Also I have written a plugin for support for Fios-G1100 router. Would you like me to make a PR for it?

@m10653 commented on GitHub (Aug 15, 2021): @brentvollebregt So testing most things work, but the following api endpoints fail. /scans/#id /devices/#id /people/#id all return a internal server error. ``` [2021-08-15 12:01:16,279] ERROR in app: Exception on /people/4 [GET] Traceback (most recent call last): File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 2070, in wsgi_app response = self.full_dispatch_request() File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1515, in full_dispatch_request rv = self.handle_user_exception(e) File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1513, in full_dispatch_request rv = self.dispatch_request() File "/usr/local/lib/python3.8/dist-packages/flask/app.py", line 1499, in dispatch_request return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args) TypeError: root() got an unexpected keyword argument 'id' ``` I tested the following urls and they work correctly: /scans /devices /people /current Also I have written a plugin for support for Fios-G1100 router. Would you like me to make a PR for it?

kerem commented

2026-02-26 12:22:20 +03:00

Author

Owner

@brentvollebregt commented on GitHub (Aug 15, 2021):

@m10653, I've just pushed a change to master to fix this.

Also, plugins are welcome! Feel free to create a PR and I can review it.

@brentvollebregt commented on GitHub (Aug 15, 2021): @m10653, I've just pushed a change to master to fix this. Also, plugins are welcome! Feel free to create a PR and I can review it.

kerem commented

2026-02-26 12:22:20 +03:00

Author

Owner

@m10653 commented on GitHub (Aug 15, 2021):

Sweet. Will do. Also your last commit seemed to fix the issue! Thanks.

@m10653 commented on GitHub (Aug 15, 2021): Sweet. Will do. Also your last commit seemed to fix the issue! Thanks.

kerem referenced this issue

2026-02-26 12:22:23 +03:00

[PR #3] [CLOSED] Bump color-string from 1.5.3 to 1.6.0 in /webapp #12

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/whos-on-my-network#3

No description provided.

Rows
Columns