[PR #851] [MERGED] Fix handling of bangs #994

New issue

Closed

opened 2026-02-25 20:37:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:37:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/benbusby/whoogle-search/pull/851
Author: @jacr13
Created: 9/23/2022
Status: ✅ Merged
Merged: 9/30/2022
Merged by: @benbusby

Base: main ← Head: fix-bangs

📝 Commits (5)

15f6e43 Fix handling of bangs
090ab5a Fix typos and switch ! check to operator
5b800c5 allow user to enter bang everywhere in query
fdbddda remove test with ! after bang
5d06864 remove development files

📊 Changes

2 files changed (+34 additions, -25 deletions)

View changed files

📝 app/utils/bangs.py (+34 -20)
📝 test/test_routes.py (+0 -5)

📄 Description

Fixes: #830

[edit] Finally, I have changed the implementation to work if the bang is at anyplace in the query.

I have also added a check to not spend time looking for an operator if a "!" is not present in the query.

I don't think we should allow the bang with the ! at the end, since this may cause some conflicts like the issue cited before, where the ! is after a word in the query, which is natural in most languages.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/benbusby/whoogle-search/pull/851 **Author:** [@jacr13](https://github.com/jacr13) **Created:** 9/23/2022 **Status:** ✅ Merged **Merged:** 9/30/2022 **Merged by:** [@benbusby](https://github.com/benbusby) **Base:** `main` ← **Head:** `fix-bangs` --- ### 📝 Commits (5) - [`15f6e43`](https://github.com/benbusby/whoogle-search/commit/15f6e432ff8b1fc7a9b40424112093dd524a76a0) Fix handling of bangs - [`090ab5a`](https://github.com/benbusby/whoogle-search/commit/090ab5a45c99c456ee77fefe2b42f6cfbde480cf) Fix typos and switch ! check to operator - [`5b800c5`](https://github.com/benbusby/whoogle-search/commit/5b800c57dc412d8bb18e2d06ba98a45fd8a6cba7) allow user to enter bang everywhere in query - [`fdbddda`](https://github.com/benbusby/whoogle-search/commit/fdbddda16c13151c76c707c454e468c7460fc7aa) remove test with ! after bang - [`5d06864`](https://github.com/benbusby/whoogle-search/commit/5d06864cc93b06b88c8b2560cce502bc2c491e20) remove development files ### 📊 Changes **2 files changed** (+34 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `app/utils/bangs.py` (+34 -20) 📝 `test/test_routes.py` (+0 -5) </details> ### 📄 Description Fixes: #830 [edit] Finally, I have changed the implementation to work if the bang is at anyplace in the query. I have also added a check to not spend time looking for an operator if a "!" is not present in the query. I don't think we should allow the bang with the ! at the end, since this may cause some conflicts like the issue cited before, where the ! is after a word in the query, which is natural in most languages. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>