mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #8] [BUG] opensearch.xml always using localhost #9
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#9
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JohnCMoon on GitHub (May 10, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/8
Originally assigned to: @benbusby on GitHub.
When using Docker behind an Nginx proxy and ran into an issue where "Adding Search Engine" with Firefox isn't working. The base URL in the opensearch.xml file ends up being "localhost:8888" instead of my host URL.
To Reproduce
Expected behavior
The browser search engine would use the actual URL of the instance (passed with the
--hostparam).Workaround
I worked around this issue by changing the
main_urlparam inroutes.pyto use my custom domain:template = render_template('opensearch.xml', main_url='<MY_URL_HERE>')@benbusby commented on GitHub (May 10, 2020):
Hey @JohnCMoon, thanks for bringing this to my attention. I just pushed an update that allows for configuration of a root URL using the config section on the main page of the app. Try setting that to your host URL and let me know if that ends up working for you.
Oh and you'll likely need to remove the existing search config for Whoogle search from your Firefox preferences before trying this again (in case you haven't done that already).
@benbusby commented on GitHub (May 15, 2020):
Closing for now, as I believe this is fixed. Feel free to reopen if that isn't the case. Thanks!
@JohnCMoon commented on GitHub (May 17, 2020):
Yep, this is fixed. Thank you!
@GyokuroT commented on GitHub (May 20, 2020):
I also run Whoogle behind a reverse proxy. Does it have any adverse effects if some random internet user changes the root URL?
@JohnCMoon commented on GitHub (May 23, 2020):
Hmm, yeah I suppose it would. Might want to keep this option server-side.