mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 04:05:57 +03:00
[PR #325] [MERGED] Implement localization framework #842
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#842
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/benbusby/whoogle-search/pull/325
Author: @benbusby
Created: 5/24/2021
Status: ✅ Merged
Merged: 5/24/2021
Merged by: @benbusby
Base:
main← Head:feature/localization📝 Commits (4)
ef6bb5fReplace hardcoded strings using translation json file041689dVerify interface lang can be used for localizationeacc712Add test for validating translation language keysc874085Validate all translations against original keyset, update readme📊 Changes
10 files changed (+219 additions, -78 deletions)
View changed files
📝
README.md(+55 -4)📝
app/__init__.py(+2 -0)📝
app/models/config.py(+13 -0)📝
app/routes.py(+6 -0)📝
app/static/settings/countries.json(+1 -1)📝
app/static/settings/languages.json(+46 -46)➕
app/static/settings/translations.json(+58 -0)📝
app/templates/display.html(+1 -1)📝
app/templates/index.html(+24 -26)📝
test/test_misc.py(+13 -0)📄 Description
Introduces a basic method of translating the Whoogle-specific UI elements
using a new "translations.json" file. Currently it only supports English
and Spanish, but is easy to add more later.
Closes #256
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.